Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to clear aggregation from dropdown #420

Merged
merged 3 commits into from
Nov 5, 2019
Merged

Allow to clear aggregation from dropdown #420

merged 3 commits into from
Nov 5, 2019

Conversation

barmac
Copy link
Member

@barmac barmac commented Oct 29, 2019 •
edited
Loading

Closes #370
Closes #389

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Oct 29, 2019
@barmac barmac changed the title Allow to clear aggregation from dropdown WIP Allow to clear aggregation from dropdown Oct 30, 2019
@barmac
Copy link
Member Author

barmac commented Oct 30, 2019

@philippfromme I marked this as WIP since @volkergersabeck and I will re-iterate over this.

@barmac barmac force-pushed the 370-add-aggregation-list-to-hit-policy-collect branch from b31f84d to 7b361c1 Compare October 31, 2019 10:22
@barmac barmac changed the title WIP Allow to clear aggregation from dropdown Allow to clear aggregation from dropdown Oct 31, 2019
@barmac
Copy link
Member Author

barmac commented Oct 31, 2019

@philippfromme ready to review

philippfromme
philippfromme approved these changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@philippfromme philippfromme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@fake-join fake-join bot merged commit 4f6f774 into develop Nov 5, 2019
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 5, 2019
@fake-join fake-join bot deleted the 370-add-aggregation-list-to-hit-policy-collect branch November 5, 2019 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippfromme philippfromme philippfromme approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@barmac @philippfromme