Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DMN Overlay buttons must have discernible text #842

Closed
vpellegrino opened this issue Mar 28, 2024 · 4 comments
Closed

DMN Overlay buttons must have discernible text #842

vpellegrino opened this issue Mar 28, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@vpellegrino
Copy link
Contributor

vpellegrino commented Mar 28, 2024

Describe the Bug

The buttons used for navigating from the DRD to the Decision Table or the Literal Expression definitions must have text that describes their purpose.

Axe recommendation:
To solve this problem, you need to fix at least (1) of the following:

  • Element does not have inner text that is visible to screen readers
  • aria-label attribute does not exist or is empty
  • aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
  • Element has no title attribute
  • Element's default semantics were not overridden with role="none" or role="presentation"

image

My suggestion is to just add a title attribute to the buttons, with a small explanation of the button purpose (e.g. title="Navigate to the Decision Table definition").

Steps to Reproduce

Steps to reproduce the behavior:

  1. Open the DMN editor (for example, on the Web Modeler)
  2. Create a new Decision Table/Literal Expression
  3. Execute the page scan, by using the "axe DevTools" extension

Expected Behavior

The axe scan reports no accessibility issue related to the overlay buttons.

Environment

Please complete the following information:

@vpellegrino vpellegrino added the bug Something isn't working label Mar 28, 2024
@vpellegrino
Copy link
Contributor Author

@nikku, feel free to include this one in https://github.com/bpmn-io/internal-docs/issues/909

@vpellegrino
Copy link
Contributor Author

@barmac was this issue fixed too with this bump?

@barmac
Copy link
Member

barmac commented Apr 5, 2024

Correct, this is supposed to be fixed in v16.1.0

@nikku nikku closed this as completed Apr 8, 2024
@nikku
Copy link
Member

nikku commented Apr 8, 2024

Fixed, cf. #842 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

3 participants