BKM as literal expression

[barmac]

Screen.Recording.2024-04-25.at.17.17.18.mov

Closes #826

Test via npx @bpmn-io/sr bpmn-io/dmn-js#826-bkm-as-literal-expression

[barmac]

TODO:

• Rebase on top of main
• Make sure function kind doesn't change its size unnecessarily
• Include parameters in the suggestions
• ...

[barmac]

Include parameters in the suggestions

Extracted to #853 as it needs to be solved in https://github.com/bpmn-io/dmn-variable-resolver

[barmac]

This should work but doesn't:
npx @bpmn-io/sr bpmn-io/dmn-js#826-bkm-as-literal-expression

I will update the demo website.

[barmac]

There was no need to update the website as the one-liner above works just fine.

[barmac]

It looks like we are suffering from npm/cli#4828 on the CI

[barmac]

Given we add an input-like border around the name, is it sufficient?

I'm sorry, I misunderstood. I meant that I thought it was enough to have the border around the name when it's in edit mode, since the user can edit the BKM name elsewhere. I'm not sure about the border being visible all the time; without a visible label, the box feels a bit non-standard to me. If we could make the name consistent with the other header items and show the edit button on hover, I think that might be best. @crobbins215, any thoughts? (Apologies again for the misunderstanding.)

I'd say let's keep this in mind for the follow-up improvements, so that we can learn from user's feedback.

[barmac]

@philippfromme @nikku @marstamm Please have a look at this. There are some follow-up issues linked in the product hub, but I'd like to work on them separately from this PR.

[barmac]

TODO: Make inputs commit on blur, and have a separate command stack (browser native) instead of diagram-js command stack.

[marstamm]

Found some smaller things that we can address, but nothing major. As discussed, I opened #858 as it is not a regression

[barmac]

TODO: Make inputs commit on blur, and have a separate command stack (browser native) instead of diagram-js command stack.

I will extract this in a separate issue. This is broken already in dmn-js-literal-expression, and it's a bigger issue than I thought because we need to change multiple components to make it work correctly.

[barmac]

I created #859 as a follow-up.

[marstamm]

With the Follow-ups we discussed, I think we are good to merge. Great Job 🚀