-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make inputs commit on blur, and let browser handle undo/redo #859
Comments
Additional context:
https://camunda.slack.com/archives/GP70M0J6M/p1715331428555569 |
The FEEL editor relies on CodeMirror's updateListener to call the change handler. However, such updates behave much more closely to the browser |
We could consider to change the FEEL editor |
Agreed, but that means a breaking change if we modify the |
Make inputs commit on blur, and have a separate command stack (browser native) instead of diagram-js command stack.
Originally posted by @barmac in #852 (comment)
Describe the Bug
Right now the inputs commit to the command stack which results in:
Steps to Reproduce
Steps to reproduce the behavior:
If you report a modeling related issue, ensure you can reproduce it on demo.bpmn.io
When reporting a library error, try to build an example that reproduces your problem. You can use our playgrounds for viewer or modeler as a starting point or put a demo up on GitHub for inspection.
Expected Behavior
Browser and code editor library handle inputs while command stack handles all the rest. Single undo outside of the input undoes the entire input change.
Environment
Please complete the following information:
The text was updated successfully, but these errors were encountered: