Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeError: e.scrollIntoViewIfNeeded is not a function #10

Closed
jurgenhaas opened this issue Mar 28, 2022 · 5 comments · Fixed by #11
Closed

TypeError: e.scrollIntoViewIfNeeded is not a function #10

jurgenhaas opened this issue Mar 28, 2022 · 5 comments · Fixed by #11
Assignees
@nikku
Labels
bug Something isn't working

Comments

@jurgenhaas
Copy link
Contributor

Describe the Bug

Just updated to the latest version 0.0.3 - great work everyone and big thank you!

The only issue: when clicking on "+ Select" for a template, the template chooser opens but the browser console outputs this exception:

Uncaught (in promise) TypeError: e.scrollIntoViewIfNeeded is not a function
    AR https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    SR https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    __h https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    __c https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    __c https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    JA https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    A https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    $A https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    FA https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    setState https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    __ https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    AR https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    SR https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    wR https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    setTimeout handler*n https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    diffed https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    diffed https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    XA https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    HA https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    __e https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    XA https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    HA https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    __e https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    XA https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    HA https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    XA https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    HA https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    XA https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    tR https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    _refresh https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:74
    open https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:82
    open https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:62
    TR https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    r https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    _invokeListener https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    _invokeListeners https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    fire https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    onClick https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    Wg https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    Gg https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    Jg https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    Jg https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    Yg https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    Fg https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    Yg https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    Fg https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    Yg https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    Fg https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    Yg https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    Fg https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    Jg https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    Yg https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    Fg https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    Jg https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    Yg https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    Fg https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    Jg https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    Yg https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    Fg https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    Yg https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    Fg https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    Jg https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    Yg https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    Fg https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    Jg https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    Yg https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    Fg https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    Yg https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2
    Fg https://danse.dev.jurgenhaas.de/modules/contrib/bpmn_io/webpack/bpmn-modeller.js?v=8.7.1:2

Selecting a template with the mouse works, but keyboard interaction doesn't. I can't scroll with the keyboard and search doesn't work either. Both is certainly a follow-up error off the exception.

Environment

Library versions:

  • diagram-js@8.2.1
  • camunda-bpmn-moddle@6.1.2
  • min-dash@3.8.1
  • jquery@3.6.0
  • bpmn-js@9.0.3
  • @bpmn-io/element-template-chooser@0.0.3
  • @bpmn-io/properties-panel@0.12.0
  • bpmn-js-properties-panel@1.0.0-alpha.7
@jurgenhaas jurgenhaas added the bug Something isn't working label Mar 28, 2022
@rpkoller
Copy link

rpkoller commented Mar 28, 2022 •
edited

probably related with this issue #6 and the commit fixing it: 44b16fb . src/element-template-chooser/ElementTemplateChooser.js gets added that function shown in the typeerror in line 141?

@nikku
Copy link
Member

nikku commented Mar 28, 2022

Please provide all details, including your browser environment.

@jurgenhaas
Copy link
Contributor Author

I'm on Ubuntu 20.04 with Firefox 98.0.2

@nikku
Copy link
Member

nikku commented Mar 28, 2022

Thanks for reporting.

Firefox apparently does not support this API.

@nikku nikku self-assigned this Mar 28, 2022
nikku added a commit that referenced this issue Mar 28, 2022
@nikku
fix: scroll into view on Firefox
7a8b2f7 
Closes #10
@nikku nikku mentioned this issue Mar 28, 2022
Merged
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Mar 28, 2022
@nikku nikku closed this as completed in #11 Mar 28, 2022
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Mar 28, 2022
nikku added a commit that referenced this issue Mar 28, 2022
@nikku
fix: scroll into view on Firefox
52dbaf4 
Closes #10
@nikku
Copy link
Member

nikku commented Mar 28, 2022

Released with v0.0.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikku nikku

Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update UI bpmn-io/element-template-chooser
3 participants
@nikku @jurgenhaas @rpkoller