Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When navigating a long list by the keyboard the list doesn't scroll #6

Closed
rpkoller opened this issue Mar 21, 2022 · 3 comments
Closed
Assignees
Labels
a11y bug Something isn't working

Comments

@rpkoller
Copy link

Describe the Bug
For long lists #3 has limited the height of the template chooser to prevent that the list extends below the fold. Problem is if you navigate the list by the cursor keys on the keyboard and you navigate down as soon as the last visible template is reached the focus disappears because the list doesn't scroll.

Steps to Reproduce

  1. open the template chooser (in case you have more templates available than the height of the template chooser)
  2. hit the down key until the focus area disappears

Expected Behavior
the scroll position should mind the position of the focus area

Environment

  • Host (Browser/Node version), if applicable: Safari 13.1.2, Firefox 98.0.1
  • OS: MacOS 10.13.6
  • Library version: "@bpmn-io/element-template-chooser": "0.0.1"
@rpkoller rpkoller added the bug Something isn't working label Mar 21, 2022
@barmac
Copy link
Member

barmac commented Mar 22, 2022

I am able to reproduce this issue. We are happy to accept external contributions. You are welcome to provide a solution.

@barmac barmac added the backlog Queued in backlog label Mar 22, 2022
@rpkoller
Copy link
Author

@barmac unfortunately i don't consider myself a developer therefor in regards of implementation, for javascript in particular, i am not much of a help. :/ i know html and css and am able to notice possible problematic parts but due to the fact not being a frontend dev creating something on my own takes me a significant amount of time longer. i am more comfortable and savvy in the field of content strategy and additionally in ux and a11y.

@barmac
Copy link
Member

barmac commented Mar 24, 2022

That is fine. Thank you for getting back :)

@barmac barmac added good first issue Good for newcomers pr welcome We rely on a community contribution to improve this. labels Mar 24, 2022
nikku added a commit that referenced this issue Mar 24, 2022
@nikku nikku mentioned this issue Mar 24, 2022
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed backlog Queued in backlog labels Mar 24, 2022
@nikku nikku removed pr welcome We rely on a community contribution to improve this. good first issue Good for newcomers labels Mar 26, 2022
@nikku nikku closed this as completed in 44b16fb Mar 27, 2022
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y bug Something isn't working
Development

No branches or pull requests

4 participants