Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent invalid key from being entered #58

Closed
philippfromme opened this issue May 14, 2021 · 1 comment · Fixed by #127
Closed

Prevent invalid key from being entered #58

philippfromme opened this issue May 14, 2021 · 1 comment · Fixed by #127
Assignees
@philippfromme
Labels
bug Something isn't working editor
Milestone
F3

Comments

@philippfromme
Copy link
Contributor

philippfromme commented May 14, 2021 •
edited
Loading

The properties panel has no built-in validation. It should prevent any invalid key (duplicates as well as empty ones).

yLvF9xLRjA

Reproduce

  1. Set the key of a field
  2. Set the key of another field to the same value

Expected Behavior

  1. Duplicate keys are prevented
  2. Empty keys are prevented
  3. ➡️ All diagrams that are configurable via the form-js editor shall be valid, i.e. importable again in editor and viewer instances.
@philippfromme philippfromme added the bug Something isn't working label May 14, 2021
@nikku nikku added the editor label May 17, 2021
@nikku nikku added the backlog Queued in backlog label May 17, 2021 — with bpmn-io-tasks
@nikku nikku added this to the F2 milestone May 17, 2021
@nikku nikku modified the milestones: F2, F3 Jun 17, 2021
@nikku nikku changed the title Duplicate keys Not Prevented Prevent invalid key from being entered Jul 8, 2021
@nikku nikku mentioned this issue Jul 8, 2021
Closed
@nikku
Copy link
Member

nikku commented Jul 8, 2021

Given the fact that this can easily result in someone breaking her forms in a way that is impossible to recover from I'd love to give this some priority.

@nikku nikku added ready Ready to be worked on and removed backlog Queued in backlog labels Jul 8, 2021
@philippfromme philippfromme self-assigned this Jul 9, 2021
philippfromme added a commit that referenced this issue Jul 9, 2021
@philippfromme
feat(editor): validate key
20f3862 
Closes #58
Related to camunda/camunda-modeler#2358
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Jul 9, 2021
@philippfromme philippfromme mentioned this issue Jul 9, 2021
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Jul 9, 2021
philippfromme added a commit that referenced this issue Jul 13, 2021
@philippfromme
feat(editor): validate key
6c760c0 
Closes #58
Related to camunda/camunda-modeler#2358
philippfromme added a commit that referenced this issue Jul 13, 2021
@philippfromme
feat(editor): validate key
f83f6cb 
Closes #58
Related to camunda/camunda-modeler#2358
@fake-join fake-join bot closed this as completed in #127 Jul 13, 2021
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jul 13, 2021
fake-join bot pushed a commit that referenced this issue Jul 13, 2021
@philippfromme @fake-join
feat(editor): validate key
e07c884 
Closes #58
Related to camunda/camunda-modeler#2358
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philippfromme philippfromme

Labels
bug Something isn't working editor
Milestone
F3
Development

Successfully merging a pull request may close this issue.

feat(editor): validate key bpmn-io/form-js
2 participants
@nikku @philippfromme