feat: use template engine mustache to render textfield #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR @jonathanlukas! Could you add a test case to show how the binding is meant to be used? On our end we need to clarify what template language we want to use for templating, and support that language full stack. CC @christian-konrad Mustache is a strong player due to it's safety and simplicity, but it is also fairly opinionated (cf. docs). |
This was referenced Aug 9, 2022
|
Closing this as a stalled PR. Feel free to comment once you have time to look into this again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #247
Markdown coming from the text area will now be rended against a template context if available.
Mustache is used as template engine which is also stated in the description of the text area now.