Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEEL support for min, max, minLength and maxLength #668

Merged
merged 3 commits into from
Jun 19, 2023

Conversation

pinussilvestrus
Copy link
Contributor

@pinussilvestrus pinussilvestrus commented May 25, 2023

Related to #653

Adds FEEL support for min, max, minLength and maxLength validation.

Demo: https://demo-653-min-max-feel--camunda-form-playground.netlify.app/

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label May 25, 2023
@pinussilvestrus pinussilvestrus changed the base branch from develop to 653-labels-descriptions-others May 25, 2023 12:35
@github-actions github-actions bot temporarily deployed to demo-653-min-max-feel May 25, 2023 12:35 Destroyed
@github-actions github-actions bot temporarily deployed to demo-653-min-max-feel May 25, 2023 12:35 Destroyed
@pinussilvestrus pinussilvestrus changed the base branch from 653-labels-descriptions-others to 653-adorners-images May 25, 2023 12:35
@github-actions github-actions bot temporarily deployed to demo-653-min-max-feel May 25, 2023 13:21 Destroyed
@github-actions github-actions bot temporarily deployed to demo-653-min-max-feel May 26, 2023 07:14 Destroyed
@github-actions github-actions bot temporarily deployed to demo-653-min-max-feel May 26, 2023 07:52 Destroyed
@github-actions github-actions bot temporarily deployed to demo-653-min-max-feel May 26, 2023 07:54 Destroyed
@github-actions github-actions bot temporarily deployed to demo-653-min-max-feel May 26, 2023 12:40 Destroyed
@pinussilvestrus pinussilvestrus force-pushed the 653-adorners-images branch 2 times, most recently from fa58000 to f80bdb7 Compare May 26, 2023 14:52
@github-actions github-actions bot temporarily deployed to demo-653-min-max-feel May 26, 2023 14:52 Destroyed
@github-actions github-actions bot temporarily deployed to demo-653-min-max-feel May 30, 2023 07:16 Destroyed
@github-actions github-actions bot temporarily deployed to demo-653-min-max-feel May 30, 2023 14:22 Destroyed
@github-actions github-actions bot temporarily deployed to demo-653-min-max-feel June 12, 2023 08:58 Destroyed
Base automatically changed from 653-adorners-images to develop June 13, 2023 06:54
@github-actions github-actions bot temporarily deployed to demo-653-min-max-feel June 13, 2023 07:00 Destroyed
@pinussilvestrus pinussilvestrus marked this pull request as ready for review June 13, 2023 07:01
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Jun 13, 2023
@github-actions github-actions bot temporarily deployed to demo-653-min-max-feel June 13, 2023 07:01 Destroyed
@pinussilvestrus
Copy link
Contributor Author

This is ready for review now. 👍

@github-actions github-actions bot temporarily deployed to demo-653-min-max-feel June 15, 2023 13:23 Destroyed
@pinussilvestrus
Copy link
Contributor Author

@christian-konrad @RomanKostka are you able to review this before the Retreat? So we can close the last one before the break 🙂

Copy link

@RomanKostka RomanKostka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!
looks good to me :)

@github-actions github-actions bot temporarily deployed to demo-653-min-max-feel June 16, 2023 12:14 Destroyed
@pinussilvestrus pinussilvestrus merged commit 4d632db into develop Jun 19, 2023
9 of 10 checks passed
@pinussilvestrus pinussilvestrus deleted the 653-min-max-feel branch June 19, 2023 07:25
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jun 19, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants