fix: properly handle all formats of options sources #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
demo-960-fix-dynamic-options
vsgoulart
reviewed
Jan 3, 2024
| export function useLabelCorrelation(options) { | ||
|
|
||
| // This allows us to retrieve the label from a value in linear time | ||
| const labelMap = useMemo(() => Object.assign({}, ...options.map((o) => ({ [_getValueHash(o.value)]: o.label }))), [ options ]); |
There was a problem hiding this comment.
Did you have any performance issues? It's not a good idea to abuse useMemo,useCallback, etc because of memory leaks
There was a problem hiding this comment.
Yeah, this is why it's here and it's always been that way. I've just brought this pattern into a hook because we use it a few places. Otherwise the complexity is n^2 and we want the components to deal with values of n > 1000
| * This hook allows us to retrieve the label from a value in linear time by caching it in a map | ||
| * @param {Array} options | ||
| */ | ||
| export function useLabelCorrelation(options) { |
There was a problem hiding this comment.
Suggested change
| export function useLabelCorrelation(options) { | |
| export function useGetLabelCorrelation(options) { |
| @@ -64,8 +66,7 @@ export default function Taglist(props) { | |||
| onChange: props.onChange | |||
| }); | |||
|
|
|||
| // We cache a map of option values to their index so that we don't need to search the whole options array every time to correlate the label | |||
| const valueToOptionMap = useMemo(() => Object.assign({}, ...options.map((o, x) => ({ [o.value]: options[x] }))), [ options ]); | |||
| const correlateLabel = useLabelCorrelation(options); | |||
There was a problem hiding this comment.
Suggested change
| const correlateLabel = useLabelCorrelation(options); | |
| const getLabelCorrelation = useLabelCorrelation(options); |
| @@ -19,6 +20,15 @@ export function sanitizeDateTimePickerValue(options) { | |||
| return value; | |||
| } | |||
|
|
|||
| export function isDeepIncluded(value, array) { | |||
There was a problem hiding this comment.
The name is not very descriptive, I think we can improve it
Suggested change
| export function isDeepIncluded(value, array) { | |
| export function hasEqualValue(value, array) { |
| @@ -1,4 +1,5 @@ | |||
| import { useRef } from 'preact/hooks'; | |||
| import isDeepEqual from 'lodash/isEqual'; | |||
There was a problem hiding this comment.
Let's not rename it unless it's necessary
Suggested change
| import isDeepEqual from 'lodash/isEqual'; | |
| import isEqual from 'lodash/isEqual'; |
github-actions
bot
temporarily deployed
to
demo-960-fix-dynamic-options
Skaiir
force-pushed
the
960-fix-dynamic-options
branch
from
167dbc4
to
897cbf9
Compare
github-actions
bot
temporarily deployed
to
demo-960-fix-dynamic-options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #960