Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all inputs controlled #155

Closed
marstamm opened this issue Jun 7, 2022 · 1 comment · Fixed by #159
Closed

Make all inputs controlled #155

marstamm opened this issue Jun 7, 2022 · 1 comment · Fixed by #159
Assignees
@smbea
Labels
bug Something isn't working ux

Comments

@marstamm
Copy link
Contributor

marstamm commented Jun 7, 2022

What should we do?

Why should we do it?

#146 was only reported on Text inputs so far, but is also possible for other input types. To prevent input loss, we should convert them all to the pattern introduced with #154
@marstamm marstamm added the backlog Queued in backlog label Jun 7, 2022
@marstamm marstamm mentioned this issue Jun 7, 2022
Merged
@nikku nikku added the ready Ready to be worked on label Jun 30, 2022 — with bpmn-io-tasks
@nikku nikku removed the backlog Queued in backlog label Jun 30, 2022
@nikku
Copy link
Member

nikku commented Jun 30, 2022 •
edited
Loading

Moving this to ready.

This is a massive UX issue reported in many places (Camunda Web Modeler, Camunda Desktop Modeler, ...).

@nikku nikku added bug Something isn't working ux labels Jun 30, 2022
@smbea smbea self-assigned this Jul 1, 2022
smbea added a commit that referenced this issue Jul 1, 2022
@smbea
chore(inputs): make input fields controlled
eb1e9e7 
Closes #155
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Jul 1, 2022
@smbea smbea mentioned this issue Jul 1, 2022
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Jul 1, 2022
@nikku nikku closed this as completed in #159 Jul 1, 2022
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jul 1, 2022
nikku pushed a commit that referenced this issue Jul 1, 2022
@smbea @nikku
chore(inputs): make input fields controlled
65d9ae0 
Closes #155
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smbea smbea

Labels
bug Something isn't working ux
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make all input fields controlled bpmn-io/properties-panel
3 participants
@nikku @marstamm @smbea