Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEEL popup menu should be a drag trap #289

Closed
nikku opened this issue Sep 25, 2023 · 0 comments · Fixed by #292
Closed

FEEL popup menu should be a drag trap #289

nikku opened this issue Sep 25, 2023 · 0 comments · Fixed by #292
Assignees
@pinussilvestrus
Labels
enhancement New feature or request

Comments

@nikku
Copy link
Member

nikku commented Sep 25, 2023

Is your feature request related to a problem? Please describe.

As I'm integrating the FEEL popup menu inside my application I want to safely do so, handle events that I require to handle, and don't interfere with existing application logic. To accomplish this it must act as a focus, click, and keyboard trap, but also a drag trap.

This allows us to safely integrate the menu, and not cause quirks:

capture Rfj2MQ_optimized

Describe the solution you'd like

As an outside application I want to either (1) not know about popup menu drag events or (2) understand that these have already been handled, so that I don't invoke my own drag (and drop) logic.

Describe alternatives you've considered

The application may know that the menu exists, and workaround it somehow. However we'd need to create these workarounds in all applications.

Additional context

Raised in the context of camunda/camunda-modeler#3877, https://github.com/camunda/web-modeler/issues/5892.
@nikku nikku added the enhancement New feature or request label Sep 25, 2023
@nikku nikku mentioned this issue Sep 25, 2023
Closed
5 tasks
@pinussilvestrus pinussilvestrus self-assigned this Sep 25, 2023
@nikku nikku added the backlog Queued in backlog label Sep 25, 2023 — with bpmn-io-tasks
pinussilvestrus pushed a commit that referenced this issue Sep 25, 2023
fix(util/dragger): handle dragover events during capture phase
9c027f2 
We need to do this to make sure we track cursor movements before we reach other drag event handlers, e.g. in child containers.

Related to #289
Related to https://github.com/camunda/web-modeler/issues/5892#issuecomment-1733155870
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed backlog Queued in backlog labels Sep 25, 2023
@pinussilvestrus pinussilvestrus mentioned this issue Sep 25, 2023
Merged
pinussilvestrus pushed a commit that referenced this issue Sep 25, 2023
fix(util/dragger): handle dragover events during capture phase
86254de 
We need to do this to make sure we track cursor movements before we reach other drag event handlers, e.g. in child containers.

Related to #289
Related to https://github.com/camunda/web-modeler/issues/5892#issuecomment-1733155870
pinussilvestrus pushed a commit that referenced this issue Sep 26, 2023
fix(util/dragger): handle dragover events during capture phase
0694e2f 
We need to do this to make sure we track cursor movements before we reach other drag event handlers, e.g. in child containers.

Related to #289
Related to https://github.com/camunda/web-modeler/issues/5892#issuecomment-1733155870
pinussilvestrus pushed a commit that referenced this issue Sep 26, 2023
feat(feel-popup): fire dragging events
9aca948 
Closes #289
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Sep 26, 2023
pinussilvestrus pushed a commit that referenced this issue Sep 26, 2023
feat(feel-popup): fire dragging events
d6feb96 
Closes #289
@fake-join fake-join bot closed this as completed in #292 Sep 26, 2023
fake-join bot pushed a commit that referenced this issue Sep 26, 2023
@fake-join
fix(util/dragger): handle dragover events during capture phase
64f660e 
We need to do this to make sure we track cursor movements before we reach other drag event handlers, e.g. in child containers.

Related to #289
Related to https://github.com/camunda/web-modeler/issues/5892#issuecomment-1733155870
fake-join bot pushed a commit that referenced this issue Sep 26, 2023
@fake-join
feat(feel-popup): fire dragging events
bdda584 
Closes #289
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pinussilvestrus pinussilvestrus

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drag trap for popups bpmn-io/properties-panel
2 participants
@nikku @pinussilvestrus