Drag trap for popups #292
Merged
Drag trap for popups #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikku
reviewed
Sep 25, 2023
nikku
reviewed
Sep 25, 2023
pinussilvestrus
force-pushed
the
289-drag-trap
branch
from
0f5bf41
to
4ecbcfd
Compare
|
Make it work in Web Modeler (locally) without flickering 🍏
|
pinussilvestrus
force-pushed
the
289-drag-trap
branch
from
4ecbcfd
to
9fd5e1d
Compare
added 3 commits
September 26, 2023 10:11
* Do not bubble up dragstart events * Do not bubble up dragover events
We need to do this to make sure we track cursor movements before we reach other drag event handlers, e.g. in child containers. Related to #289 Related to https://github.com/camunda/web-modeler/issues/5892#issuecomment-1733155870
pinussilvestrus
force-pushed
the
289-drag-trap
branch
from
9fd5e1d
to
9aca948
Compare
bpmn-io-tasks
bot
added
needs review
|
@bpmn-io/modeling-dev this is ready for review 👍 |
pinussilvestrus
commented
Sep 26, 2023
nikku
reviewed
Sep 26, 2023
nikku
reviewed
Sep 26, 2023
nikku
reviewed
Sep 26, 2023
pinussilvestrus
force-pushed
the
289-drag-trap
branch
from
9aca948
to
d6feb96
Compare
nikku
approved these changes
Sep 26, 2023
|
@pinussilvestrus You take care of releasing this? |
|
Will do ✅ Will you take care of bumping versions downstream in BPMN land? |
|
Released via 55f1e47 |
pinussilvestrus
pushed a commit
to bpmn-io/form-js
that referenced
this pull request
Sep 26, 2023
|
We'll bump downstream. Thanks ❤️ |
pinussilvestrus
pushed a commit
to bpmn-io/form-js
that referenced
this pull request
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #289