fix(hooks): set sticky correctly on element change #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marstamm
requested review from
pinussilvestrus and
smbea
and removed request for
a team
barmac
reviewed
Aug 16, 2022
marstamm
force-pushed
the
fix-sticky-headers
branch
from
5bf9b93
to
90fa0f0
Compare
|
Try out via |
nikku
reviewed
Aug 16, 2022
|
Good catch @nikku. This is a z-index issue that we should fix in the headers. The FEEL marker already uses z-index 1, so the header should use something higher. I'll adjust the PR |
nikku
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to bpmn-io/bpmn-js-properties-panel#726
(see issue for why this was broken)