feat(feel-popup): allow defining popup container #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinussilvestrus
requested review from
Skaiir,
a team,
smbea and
barmac
and removed request for
a team
This was referenced Sep 7, 2023
nikku
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #277
This allows to set the parent container of the FEEL popup via a property. The default keeps
document.body.For context: We had problems in the Web Modeler properly cleaning up the popups when navigating outside of the editor (cf. https://camunda.slack.com/archives/C046XS3GGCR/p1693400946971909). For example, in the forms editor, we can set the container to the Form Playground Root.
Cf. to the implementation in form-js as an example of how to use this.