Merge pull request #1405 from martinRenou/do_not_relayout_unneeded

Speedup: Do not relayout if not needed
bqplot · Sep 30, 2021 · 645aa4f · 645aa4f
2 parents 96b0b93 + 0b49ede
commit 645aa4f
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/js/src/Figure.ts b/js/src/Figure.ts
@@ -759,13 +759,7 @@ export class Figure extends DOMWidgetView {
       case 'after-show':
       case 'after-attach':
         if (this.pWidget.isVisible) {
-          const figureSize = this.getFigureSize();
-          if (
-            this.width !== figureSize.width ||
-            this.height !== figureSize.height
-          ) {
-            this.debouncedRelayout();
-          }
+          this.debouncedRelayout();
         }
         break;
     }
@@ -775,6 +769,12 @@ export class Figure extends DOMWidgetView {
     const relayoutImpl = () => {
       this.relayoutRequested = false; // reset relayout request
       const figureSize = this.getFigureSize();
+
+      if (this.width == figureSize.width && this.height == figureSize.height) {
+        // Bypass relayout
+        return;
+      }
+
       this.width = figureSize.width;
       this.height = figureSize.height;
       // update ranges