New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.12.3 release #999
Comments
merge / review "Pie: Fix label display" by @martinRenou #1000
|
merge / review "Fix simple typo: resepect" -> respect #987 by @timgates42 merge / review "Fixing unwanted scrollbar when BQPlot figures are wrapped in a VBox" #941 by @ibdafna #990 |
Review/merge #969 |
I just released 0.12.3, so perhaps what is left can be on 0.12.4? A check of the above PRs shows that these are left:
And this one is backwards-incompatible, so not a candidate for 0.12.x: Am I missing any more? |
#1014 is backward-incompatible for the TypeScript package, so I guess it is safe to add it to 0.12.x |
If it is backwards-incompatible, then it is not safe to go in 0.12.x, right? |
I mean the TypeScript package would need to go from |
bqplot 0.12.3 depends on the js package |
Well, we would need to bump the js package specification in the Python package to make it work. But the Python package would not be backward-incompatible from the user perspective. |
(This is part of the reason why I advocate for the model_module_version and view_module_version to actually be the attribute spec version, not the actual js version. In this case, since the model attributes actually do not change, there is no reason for an upgrade in the js package to require a bump in the python package, other than the assumption that the attribute spec version is actually the js package version) |
Suppose I have bqplot 0.12.3 installed, and I Have we had major upgrades in the js package before with only minor upgrades in the python package? |
I agree it is confusing, I guess it is a very good argument against bumping the js package version without bumping the Python one.
I made a PR adding in the README the Python/TypeScript version mapping: https://github.com/bloomberg/bqplot/pull/1021/files and it looks like we did not do that since
|
👍 👍 👍 👍 I totally agree with that |
Yes, that is weird in 0.9. |
The two points @SylvainCorlay always brings up are:
|
I suppose this can be closed now |
This issue is meant to track the progress towards 0.12.3
The text was updated successfully, but these errors were encountered: