Plotting Widgets #1505
Plotting Widgets #1505
Conversation
|
Will review this week. |
|
@ChakriCherukuri issue seems to be upstream with The dType is defined there in the constructor. |
|
Please unsubscribe me from this Thx |
Hi there, no one subscribed you - only you can subscribe yourself to updates. Check if you're following the repo or something like that. There's nothing we can do for you on our end. Thanks! |
|
Ok I’ve unsubscribed from anything I’m connected to. All I can do I guess
is delete my GitHub account 🙁. Thx for responding.
On Thu, Jul 21, 2022 at 2:30 PM Itay Dafna ***@***.***> wrote:
Please unsubscribe me from this Thx
Hi there, no one subscribed you - only you can subscribe yourself to
updates. Check if you're following the repo or something like that. There's
nothing we can do for you on our end. Thanks!
—
Reply to this email directly, view it on GitHub
<#1505 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADCNFJORYFEFETBAP3742E3VVGJLPANCNFSM52XMT7BQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
--
Lcleary
|
|
@martinRenou can you please advise how to fix the traittypes warnings? thx |
This sounds a bit radical ahah. You have an "unsubscribe" link in the email you received, maybe clicking it could help: https://github.com/notifications/unsubscribe-auth/ADCNFJORYFEFETBAP3742E3VVGJLPANCNFSM52XMT7BQ @ChakriCherukuri Sure I'll try to find time to have a look |
|
@chakri I pointed out where the issue is above. We'll need an upstream PR
to traittypes
…On Wed, Jul 27, 2022, 16:35 martinRenou ***@***.***> wrote:
All I can do I guess is delete my GitHub account 🙁
This sounds a bit radical ahah. You have an "unsubscribe" link in the
email you received, maybe clicking it could help:
https://github.com/notifications/unsubscribe-auth/ADCNFJORYFEFETBAP3742E3VVGJLPANCNFSM52XMT7BQ
@ChakriCherukuri <https://github.com/ChakriCherukuri> Sure I'll try to
find time to have a look
—
Reply to this email directly, view it on GitHub
<#1505 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFZICWPZON33GW2H6XOPWV3VWFCLLANCNFSM52XMT7BQ>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
So @ibdafna can you merge it then? |
| t = np.linspace(0, 2 * np.pi, 1000) | ||
| band_data_x, band_data_y = ( | ||
| self.scaled_band_data * np.cos(t), | ||
| self.scaled_band_data * np.sin(t), | ||
| ) |
There was a problem hiding this comment.
It would be nice to have a Circle primitive (similar to the Lines one), so we don't need to create a circle based on a thousand segments.
This would be more efficient as it would mean sending 3 float values (center + radius) instead of 2000 float values to the front-end.
Just adding this as a note, I don't think we should block this PR waiting for such a primitive.
|
@ibdafna @martinRenou can we please merge this if we are OK with the warnings? |
|
@martinRenou I reverted the code to use an empty DataFrame constructor. Can you please review? Thx |
|
@martinRenou can you please merge if this looks good? |
|
Thanks! We should get the CI green before merging |
|
meeseeksdev please backport to 0.12.x |
…5-on-0.12.x Backport PR #1505 on branch 0.12.x (Plotting Widgets)
Added plotting widgets module which contains compound plotting widgets which subclass Figure