Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update ci, backport of #1550 #1588

Merged

Conversation

maartenbreddels
Copy link
Member

No description provided.

@maartenbreddels maartenbreddels force-pushed the update_ci_backport_1550 branch 4 times, most recently from 768e806 to b96263d Compare February 24, 2023 20:44
@maartenbreddels
Copy link
Member Author

@martinRenou CI is working for 0.12.x, but not sure why this regression happened. Maybe you have seen this error before?

@martinRenou
Copy link
Member

It looks like ScatterGL does not work anymore in this branch. I've not seen this happen on master.

@maartenbreddels
Copy link
Member Author

maartenbreddels commented Mar 7, 2023

For some reason we went from yarn 1 to 3, and that broke a lot, so we're now limiting yarn to <2

@martinRenou
Copy link
Member

Yeah I see the yarn=1 constraint pop up here and there

@maartenbreddels
Copy link
Member Author

maartenbreddels commented Mar 7, 2023

@martinRenou can we get the js console output? Looking at the video, we don't get any WebGL output, so it's not a timing issue.

@maartenbreddels
Copy link
Member Author

@martinRenou found out how to get js console output, I now see

PAGE LOG: THREE.WebGLRenderer 91
PAGE LOG: THREE.WebGLShader: Shader couldn't compile.
PAGE LOG: THREE.WebGLShader: Shader couldn't compile.
PAGE LOG: THREE.WebGLProgram: shader error:  0 gl.VALIDATE_STATUS false gl.getProgramInfoLog   
PAGE LOG: WebGL: INVALID_OPERATION: useProgram: program not valid
PAGE LOG: WebGL: INVALID_OPERATION: drawElementsInstancedANGLE: no valid shader program in use
PAGE LOG: WebGL: CONTEXT_LOST_WEBGL: loseContext: context lost

So it seems there is a WebGL issue now, any ideas how to reproduce this locally? Or what can cause this? Maybe it's a playwright version issue.

@maartenbreddels maartenbreddels force-pushed the update_ci_backport_1550 branch 2 times, most recently from 843caab to 7665ae2 Compare March 14, 2023 19:07
@maartenbreddels
Copy link
Member Author

This was really tricky to get green 😫

The problem was the 22.04 ubuntu image (ubuntu-latest). I thought I already changed that, but I only changed it for 1 step, not the visual-regression-tests. Setting visual-regression-tests to ubuntu-20.04 solved it.

Still not sure what the problem is, but maybe in a year from now this problem goes away.

@maartenbreddels maartenbreddels merged commit 38feddb into bqplot:0.12.x Mar 14, 2023
@martinRenou martinRenou deleted the update_ci_backport_1550 branch March 15, 2023 08:26
maartenbreddels added a commit to maartenbreddels/nbclassic that referenced this pull request Apr 25, 2024
As of this writing, we had failure due to an osx image update:
 * https://github.com/actions/setup-python/issues/852

And in the past I have seen the same for Ubuntu images.
 * bqplot/bqplot#1588 (comment)
maartenbreddels added a commit to maartenbreddels/nbclassic that referenced this pull request Apr 26, 2024
As of this writing, we had failure due to an osx image update:
 * https://github.com/actions/setup-python/issues/852

And in the past I have seen the same for Ubuntu images.
 * bqplot/bqplot#1588 (comment)
krassowski pushed a commit to jupyter/nbclassic that referenced this pull request Apr 26, 2024
As of this writing, we had failure due to an osx image update:
 * https://github.com/actions/setup-python/issues/852

And in the past I have seen the same for Ubuntu images.
 * bqplot/bqplot#1588 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants