fix: domain should not be reset when min/max are set #1638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In bqplot#1619 we reset the domain to (0, 1) when no data is present. However, this only matters when the min/max are not set.
maartenbreddels
force-pushed
the
fix_domain_no_data_but_minmax_set
branch
from
81840a3
to
4e8ea9d
Compare
|
pytest 8 seems to trigger the failure. |
|
Thanks! Would you be able to open the same in bqscales? |
martinRenou
approved these changes
Jan 30, 2024
martinRenou
referenced
this pull request
Feb 19, 2024
* fix: set domain to (0, 1) when no data is present Fixes #1614 If no data is present, a scale has a domain of (0, 1) but if we remove the data (set it to an empty array) afterwards, we set it to (-inf, +inf) which causes rendering issues and make the bqplot figure unable to restore itself. It is more consistent to behave like no data was passed in, and use (0, 1) for the domain. * Update snapshots --------- Co-authored-by: martinRenou <martin.renou@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1619 we reset the domain to (0, 1) when no data is present. However, this only matters when the min/max are not set.
Issue found in spacetelescope/jdaviz#2661