WebGL support for bqplot (threejs based) #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maartenbreddels
force-pushed
the
webgl
branch
4 times, most recently
from
bc8c5ef
to
5874968
Compare
Open
|
@SylvainCorlay do you feel like merging this or should we first attempt to recover from lost webgl context, similar to what jupyter-threejs is doing (cc @vidartf), and make ipyvolume, jupyter-threejs and bqplot use a similar strategy for recovering. |
maartenbreddels
force-pushed
the
webgl
branch
from
74db385
to
e9cb01f
Compare
| } | ||
|
|
||
| float scale_transform_log(float domain_value, vec2 range, vec2 domain) { | ||
| float normalized = (log(domain_value) - log(domain[0])) / (log(domain[1]) - log(domain[0])); |
There was a problem hiding this comment.
log(domain_value / domain[0]) / log(domain[1] / domain[0])); (for speed?)
|
|
||
| float scale_transform_log_inverse(float range_value, vec2 range, vec2 domain) { | ||
| float normalized = (range_value - range[0]) / (range[1] - range[0]); | ||
| float domain_value = exp(normalized * (log(domain[1]) - log(domain[0])) + log(domain[0])); |
| @@ -18,6 +18,9 @@ var d3 = require("d3"); | |||
| var _ = require("underscore"); | |||
| var popperreference = require("./PopperReference"); | |||
| var popper = require("popper.js"); | |||
| var THREE = require('three') | |||
|
|
|||
| THREE.ShaderChunk['scales'] = require('raw-loader!../shaders/scales.glsl') | |||
There was a problem hiding this comment.
should we namespace scales?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for WebGL based on threejs (although I think we can also support regl). This will be the basis for #661 and #630.
It works by overlaying a canvas on top of the svg (for performance reasons). However, when a screenshot is needed, the canvas is converted to an image and embedded.