Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use bqscales #904

Merged
merged 1 commit into from Aug 25, 2021
Merged

Use bqscales #904

merged 1 commit into from Aug 25, 2021

Conversation

martinRenou
Copy link
Member

@martinRenou martinRenou commented Sep 13, 2019 •
edited

Remove all scales from bqplot and use bqscales instead.

Improvements ideas for when the scales are in a separate package:

  • make use of https://github.com/d3/d3-scale-chromatic it contains the same color schemes as what's currently available in bqplot and more.
  • have a ColorMap/ColorAxis widget (a bit like the ColorAxis widget from bqplot, but that would not require a Figure for being displayed). This would allow other libraries that will use the scales to display a color-map. Maybe make use of https://github.com/vidartf/chromabar which also uses d3-scale-chromatic

@martinRenou
Copy link
Member Author

@SylvainCorlay @maartenbreddels @JohanMabille would you like to review this PR?

@martinRenou
Copy link
Member Author

More changes coming actually. I'm using more strict TypeScript rules locally.

@martinRenou martinRenou changed the title [WIP] - Exporting scales from bqplot Exporting scales from bqplot Dec 17, 2019
@martinRenou
Copy link
Member Author

@maartenbreddels @JohanMabille Would you mind giving it a review?

JohanMabille
JohanMabille reviewed Dec 17, 2019
View reviewed changes
js/src/ScatterBase.ts Outdated Show resolved Hide resolved
@martinRenou martinRenou changed the title Exporting scales from bqplot Use bqscales Jan 26, 2021
@martinRenou martinRenou marked this pull request as draft January 26, 2021 16:57
@martinRenou
Copy link
Member Author

Even though the tests are passing, this is not yet working due to a runtime issue in bqscales, I will fix it.

@martinRenou martinRenou marked this pull request as ready for review January 28, 2021 17:13
@martinRenou
Copy link
Member Author

This PR is ready for review

@martinRenou martinRenou marked this pull request as draft August 20, 2021 13:07
@martinRenou martinRenou reopened this Aug 20, 2021
@martinRenou
Copy link
Member Author

Trigerring CI

@martinRenou martinRenou mentioned this pull request Aug 24, 2021
Merged
@martinRenou
Copy link
Member Author

kicking CI

@martinRenou martinRenou reopened this Aug 24, 2021
@martinRenou martinRenou reopened this Aug 24, 2021
@martinRenou martinRenou marked this pull request as ready for review August 25, 2021 08:10
@martinRenou martinRenou reopened this Aug 25, 2021
@martinRenou martinRenou reopened this Aug 25, 2021
@martinRenou martinRenou merged commit 8bb2279 into bqplot:master Aug 25, 2021
@martinRenou martinRenou deleted the scale branch August 25, 2021 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohanMabille JohanMabille JohanMabille left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@martinRenou @JohanMabille