Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd: Warn on unused //errtrace:skip #62

Merged
merged 2 commits into from
Nov 30, 2023
Merged

cmd: Warn on unused //errtrace:skip #62

merged 2 commits into from
Nov 30, 2023

Conversation

abhinav
Copy link
Contributor

@abhinav abhinav commented Nov 30, 2023

If we find //errtrace:skip comments on lines
that wouldn't be instrumented, print warnings about them.

Resolves #61

@abhinav
cmd: Warn on unused //errtrace:skip
6de2487 
If we find `//errtrace:skip` comments on lines
that wouldn't be instrumented, print warnings about them.

Resolves #61
prashantv
prashantv approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@prashantv prashantv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplified by partially reverting back to a map, switching it to map[int]int to track usage by line.

abhinav
abhinav commented Nov 30, 2023
View reviewed changes
Copy link
Contributor Author

@abhinav abhinav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heh good call

@abhinav abhinav merged commit 4250159 into main Nov 30, 2023
11 checks passed
@abhinav abhinav deleted the optoput-unused-warn branch November 30, 2023 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prashantv prashantv prashantv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cmd/errtrace: Warn on unused //errtrace:skip
2 participants
@abhinav @prashantv