cmd/errtrace: Tighten up opt-out matching #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strings.Contains is too wide for this purpose. It trips up even if a doc comment mentions '//errtrace:skip'. Narrow it down to a much more selective criteria: - must be a single line comment - must be at start of the comment (`foo() //errtrace:skip`) or have a space immediately before it (`foo() //nolint:bar //errtrace:skip`) - must reach end of the comment (`foo() //errtrace:skip`) or have a space (`foo() //errtrace:skip //nolint:bar`) or an opening parenthesis (`foo() //errtrace:skip(reason)`) immediately after it.
abhinav
force-pushed
the
optout-tighten
branch
from
0e6d0fe
to
ca9d5ef
Compare
Merged
To ensure that this isn't considered a multi-line comment and is processed.
prashantv
approved these changes
Nov 30, 2023
Co-authored-by: Prashant Varanasi <prashant@prashantv.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strings.Contains is too wide for this purpose.
It trips up even if a doc comment mentions '//errtrace:skip'.
Narrow it down to a much more selective criteria:
foo() //errtrace:skip)or have a space immediately before it (
foo() //nolint:bar //errtrace:skip)foo() //errtrace:skip)or have a space (
foo() //errtrace:skip //nolint:bar)or an opening parenthesis (
foo() //errtrace:skip(reason))immediately after it.