-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add slog compatibility, move to Go 1.21 #97
Open
StevenACoffman
wants to merge
7
commits into
bracesdev:main
Choose a base branch
from
StevenACoffman:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
3b53b54
Add slog compatibility, move to Go 1.21
StevenACoffman 28e08a4
Merge branch 'main' into main
abhinav a635588
Move log related code into Go 1.21 tagged file
abhinav 53fe9c1
ErrAttr: Rename key to "err"
abhinav f594d06
ErrAttr: Rename to LogAttr
abhinav b34ac28
Change key name back to error
StevenACoffman 99e9015
Merge branch 'main' into main
StevenACoffman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
module braces.dev/errtrace | ||
|
||
go 1.20 | ||
go 1.21 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
//go:build go1.21 | ||
|
||
package errtrace | ||
|
||
import ( | ||
"bytes" | ||
"log/slog" | ||
) | ||
|
||
// LogValue implements the [slog.LogValuer] interface. | ||
func (e *errTrace) LogValue() slog.Value { | ||
var outb bytes.Buffer | ||
err := writeTree(&outb, buildTraceTree(e)) | ||
if err != nil { | ||
return slog.GroupValue( | ||
slog.String("message", e.Error()), | ||
slog.Any("formatErr", err), | ||
) | ||
} | ||
|
||
return slog.StringValue(outb.String()) | ||
} | ||
|
||
// LogAttr builds a slog attribute for an error. | ||
// It will log the error with an error trace | ||
// if the error has been wrapped with this package. | ||
// Otherwise, the error message will be logged as is. | ||
// | ||
// Usage: | ||
// | ||
// slog.Default().Error("msg here", errtrace.LogAttr(err)) | ||
func LogAttr(err error) slog.Attr { | ||
return slog.Any("error", err) | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks