[CLOSED] Switching to ESLint

[core-ai-bot]

Issue by petetnt
Tuesday Dec 08, 2015 at 12:21 GMT
Originally opened as adobe/brackets#11984

---

Branched/continued from #11644, #11693

This issue was created to track down moving to ESLint separately from the existing PR (and the general ES6 support)

• Update Brackets core code to ESLint (done in [CLOSED] Dilato: Core: The rename function doesn't work from the second time #11693)
• Integrate ESLint to Brackets core@zaggino (Eslint adobe/brackets#11693 (comment))
• Decide what to do with the existing linter (JSLint)

The integration part should be easy but what about the third box? Possible options include:

• Make ESLint the preferred linter and let the user use JSLint if the user decides to do so (confusing to those who have just used JSLint in the past)
• Make ESLint the preferred linter and remove JSLint altogether (spinning it to non-core extension) (similar issues as above)
• Just let them exist side by side and the let the user configure the settings (most confusing as files get linted twice?)
• Provide UI to select the preferred linter on first launch of Brackets 1.x (most user friendly, needs UI work etc.)

@abose@ficristo@MarcelGerber

[core-ai-bot]

Comment by ficristo
Tuesday Dec 08, 2015 at 13:06 GMT

---

I've a biased opinion since I don't like particularly JSLint, but if we want it still in core it should be at the least updated.

[core-ai-bot]

Comment by abose
Tuesday Dec 08, 2015 at 13:14 GMT

---

Modified 3. We could default to ESLint only and provide a preference to enable JSLint also.

[core-ai-bot]

Comment by zaggino
Wednesday Dec 09, 2015 at 03:56 GMT

---

Submitted a PR adobe/brackets#11988

[core-ai-bot]

Comment by tclzcja
Saturday Oct 29, 2016 at 20:57 GMT

---

Since the brackets-shell ticket has been merged, does that mean ESLint will be formally included in Brackets 1.8 release? Thank you!

[core-ai-bot]

Comment by ficristo
Sunday Oct 30, 2016 at 09:18 GMT

---

@tclzcja no, that ticket is only about to use ESLint to lint brackets-shell code.
You will have still to use an extension for 1.8 for your code.

[core-ai-bot]

Comment by petetnt
Thursday Feb 02, 2017 at 21:45 GMT

---

What's the status of this?

[core-ai-bot]

Comment by zaggino
Thursday Feb 02, 2017 at 21:47 GMT

---

I can setup a PR for "Integrate ESLint to Brackets core" if desired.

[core-ai-bot]

Comment by petetnt
Thursday Feb 02, 2017 at 21:49 GMT

---

@zaggino I would ❤️ that!

[core-ai-bot]

Comment by petetnt
Thursday Sep 28, 2017 at 20:57 GMT

---

Shipped in 1.11.