Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Switching to ESLint #11984

Closed
2 of 3 tasks
petetnt opened this issue Dec 8, 2015 · 9 comments
Closed
2 of 3 tasks

Switching to ESLint #11984

petetnt opened this issue Dec 8, 2015 · 9 comments

Comments

@petetnt
Copy link
Collaborator

petetnt commented Dec 8, 2015

Branched/continued from #11644, #11693

This issue was created to track down moving to ESLint separately from the existing PR (and the general ES6 support)

The integration part should be easy but what about the third box? Possible options include:

  • Make ESLint the preferred linter and let the user use JSLint if the user decides to do so (confusing to those who have just used JSLint in the past)
  • Make ESLint the preferred linter and remove JSLint altogether (spinning it to non-core extension) (similar issues as above)
  • Just let them exist side by side and the let the user configure the settings (most confusing as files get linted twice?)
  • Provide UI to select the preferred linter on first launch of Brackets 1.x (most user friendly, needs UI work etc.)

@abose @ficristo @marcelgerber

@petetnt petetnt mentioned this issue Dec 8, 2015
@ficristo
Copy link
Collaborator

ficristo commented Dec 8, 2015

I've a biased opinion since I don't like particularly JSLint, but if we want it still in core it should be at the least updated.

@abose
Copy link
Contributor

abose commented Dec 8, 2015

Modified 3. We could default to ESLint only and provide a preference to enable JSLint also.

@zaggino
Copy link
Contributor

zaggino commented Dec 9, 2015

Submitted a PR #11988

@tclzcja
Copy link

tclzcja commented Oct 29, 2016

Since the brackets-shell ticket has been merged, does that mean ESLint will be formally included in Brackets 1.8 release? Thank you!

@ficristo
Copy link
Collaborator

@tclzcja no, that ticket is only about to use ESLint to lint brackets-shell code.
You will have still to use an extension for 1.8 for your code.

@petetnt
Copy link
Collaborator Author

petetnt commented Feb 2, 2017

What's the status of this?

@zaggino
Copy link
Contributor

zaggino commented Feb 2, 2017

I can setup a PR for "Integrate ESLint to Brackets core" if desired.

@petetnt
Copy link
Collaborator Author

petetnt commented Feb 2, 2017

@zaggino I would ❤️ that!

@petetnt
Copy link
Collaborator Author

petetnt commented Sep 28, 2017

Shipped in 1.11.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants
@zaggino @abose @petetnt @ficristo @tclzcja and others