Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] MultiBrowser Live Preview: Fix cases where url()s in CSS weren't resolved correctly #10828

Open
core-ai-bot opened this issue Aug 30, 2021 · 2 comments

Comments

@core-ai-bot
Copy link
Member

Issue by MarcelGerber
Monday Aug 22, 2016 at 23:47 GMT
Originally opened as adobe/brackets#12705


Fixes #11076 and #11936.

In cases where the referenced CSS files aren't in the same folder the HTML file is in, we had the problem that after altering the CSS, the url()s referenced in there (think background-image, @import, which the two issues above are about) were relative to the HTML instead of relative to the CSS.
My attempt at fixing this issue is to make any relative url() absolute (where the absolute path is the CSS file), that is, for example, converting a background: url(chevron.png); to a background: url(http://127.0.0.1:port/sub/chevron.png)

cc@busykai


MarcelGerber included the following code: https://github.com/adobe/brackets/pull/12705/commits

@core-ai-bot
Copy link
Member Author

Comment by zaggino
Thursday Aug 25, 2016 at 22:20 GMT


This is really nice and clean PR, LGTM

@core-ai-bot
Copy link
Member Author

Comment by MarcelGerber
Thursday Aug 25, 2016 at 22:23 GMT


Thanks@zaggino!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant