This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
MultiBrowser Live Preview: Fix cases where url()s in CSS weren't resolved correctly #12705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 23, 2016 01:41
Replace all occurrences of url() where the URL is relative to the CSS file with an absolute URL so it is relative to the CSS file, not the HTML file
|
This is really nice and clean PR, LGTM |
|
Thanks @zaggino! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11076 and #11936.
In cases where the referenced CSS files aren't in the same folder the HTML file is in, we had the problem that after altering the CSS, the
url()s referenced in there (thinkbackground-image,@import, which the two issues above are about) were relative to the HTML instead of relative to the CSS.My attempt at fixing this issue is to make any relative
url()absolute (where the absolute path is the CSS file), that is, for example, converting abackground: url(chevron.png);to abackground: url(http://127.0.0.1:port/sub/chevron.png)cc @busykai