[CLOSED] Added Extension Sorting capability according to downloads and last published date

[core-ai-bot]

Issue by saurabh95
Monday Feb 06, 2017 at 08:14 GMT
Originally opened as adobe/brackets#13080

---

Now on opening the Extension Manager, a drop-down is shown on the left side of the search bar, which indicates the sorting of extensions according to the selected criteria(currently sort methods available are Last Updated and Download Count), on change of the selection we store the the changed selection in the preferences and if the Extension Manager is invoked again, then we use the same sorting criteria which was selected by user earlier. The sorting is available for Available and Theme Extensions.
I have attached a snapshot of the feature in use where the sort order and the download count has been highlighted for illustration.

---

saurabh95 included the following code: https://github.com/adobe/brackets/pull/13080/commits

[core-ai-bot]

Comment by ficristo
Monday Feb 06, 2017 at 09:47 GMT

---

Nice! I think@zaggino and@dnbard could have some opinions on this.
See@dnbard extension: https://github.com/dnbard/brackets-extension-rating

I have two doubts:

• why we should threat the installed tab differently?
• registry_utils comes from brackets-registry: I guess it is necessary to change it but it seems to me it should be more "self contained" (= don't require Brackets code)

[core-ai-bot]

Comment by saurabh95
Monday Feb 06, 2017 at 11:46 GMT

---

@ficristo the installed tab is treated differently as we do not have the download count of the installed extensions in the installInfo, and also currently the sorting of installed extensions is done according to the update available.
Yeah we can isolate the registry_utils from Brackets code, we can pass the preference as the argument.

[core-ai-bot]

Comment by saurabh95
Monday Feb 06, 2017 at 16:16 GMT

---

@ficristo@petetnt Addressed review comments and also added some tests.

[core-ai-bot]

Comment by petetnt
Thursday Feb 09, 2017 at 22:40 GMT

---

Great stuff@saurabh95!

Some issues I spotted:

1. For me the extension manager opens on Installed page and the sort by-toggle is visible (and does nothing). Needs similar check to https://github.com/adobe/brackets/pull/13080/files#diff-3491ce7bb262eb073c8aabc3d3e064c0R376 when opening the window too.

2. The sort toggle breaks the layout with really narrow windows (but the search bar does it too). Feel free to disregard / bump to another issue.
   

3. The icons for download counts don't seem to work on Windows (10)
   

[core-ai-bot]

Comment by saurabh95
Monday Feb 13, 2017 at 04:21 GMT

---

@petetnt I have added a test for checking downloadCount in view and also added a check for active tab on launch of Extension Manager to hide/show the sort option, regarding the download icon, I will replace it with an image.

[core-ai-bot]

Comment by saurabh95
Monday Feb 20, 2017 at 06:12 GMT

---

A screenshot with the new icon.

[core-ai-bot]

Comment by swmitra
Monday Feb 20, 2017 at 06:12 GMT

---

Merging Now with the new Icon.