-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serious problem with font quality degrading over time #12345
Comments
We'll definitely look into reproducing it--just want to verify that you had subpixel-antialiasing set (or unset) in both sprint 27 and 28 when you made your comparison. Also, as a point of clarification, our XD folks actually preferred the lighter look of the font after we switched away from subpixel-antialiasing (even though we originally did it in order to avoid the animation issues you mentioned). Ultimately, I think the solution for that issue is that we'll eventually allow fonts to be configurable, so you could choose a heavier weight for the code font. That's tracked on this card, https://trello.com/c/2nfWx6wX/353-3-user-specified-font, which is currently sitting on the backlog but is fairly far down the list. The performance issues are separate--we had to put in a temporary workaround for a crash bug in CEF in the v8 optimizer, and the workaround affects the performance of code hinting. We weren't seeing huge issues in our own testing, but it seems like other people are seeing worse problems; that's being tracked in #4608. Hopefully that will go away once we can upgrade to a newer build of CEF (but later builds are causing a different crash, #4571, that we're trying to track down). |
Even though the font isn't configurable, is pretty easy to change the code or add an extension that all it does is add a new stylesheet with code to replace any font property. I wanted to make the font slightly bolder too, since it looks too thin in the new CEF so I added the next code from an extension:
|
I just don't think you should let XD people decide the font rendering for a text editor. You should follow the conventions of the OS. I think I've said that before. No other text editor on Mac has fonts this light. If they want light fonts then they will feel right at home on Windows XP. As for me, one of the big reasons I chose MacOSX was the fonts.
|
Looks like it's been like that since January. If you're talking about other parts of the UI I can take a look. |
I can weigh in on this issue now that I have a Mac. Regarding subpixel antialiasing, I tried commenting and uncommenting the line in brackets.less that |
I'm glad to see someone on the team is finally noticing this. It brings up an interesting point. How long did it take you to grow accustom to MacOSX font rendering? To me, MacOSX font rendering seemed extremely fuzzy when I first switched from Windows XP. I find Windows(even 7 and 8) font rendering extremely harsh now though. I'm just wondering if we have a bunch of Windows clear type lovers on the brackets team or something. When I was 12, I liked the Windows 95 font rendering, but I prefer MacOSX rendering now. It feels better on the eyes. Eventually, I would like to see the Brackets team to open up every other text editor on MacOSX and compare. It's weird though, Sprint 17 and below had some of the best rendering I've seen in a text editor. |
I'm still not use it but I have only had my Mac for a week. |
Hi--let me recap the issues.
|
BTW, one reason I don't think we've done much with this is that we haven't really heard other complaints about it. It might be worth starting a thread on the Google Group to see if anyone else feels the same way about the Mac rendering on non-retina. |
The reason I started this issue was to bring up that turning on subpixel after Sprint 27, no longer corrects the fonts as it did in the past. Everything, I would say, was great until 28. I don't see how anyone can't notice it, but you're right, I've been following Brackets for awhile and have never see anything on it. It's hard to believe, but some people actually prefer anti aliasing turned off for programming on MacOSX. I would argue that they would like Windows XP better(http://chrissilich.com/blog/sublime-text-font-smoothing-anti-aliasing-issues-in-mountain-lion/). This person likes the bottom picture better then the top. -_- Do you guys have any analytics on Mac vs Windows downloads, as I don't see any issues on Windows. I'm just wondering if there are just that many Windows users using Brackets, then MacOSX. Thanks! |
Is this much better? |
I don't know. maybe it all is too subjective. Maybe |
|
|
Which one is better? |
|
This is Sprint 22 with subpixel-antialised turned on and this theme default setting. .code-font-mac() {
.code-font();
/* Use the Medium weight on the Mac to counterbalance the grayscale antialiasing. */
} I took the line out where it sets SourceCodePro to medium. |
I feel like I am at an optometrist appointment. |
First one is using subpixel-antialiasing with light gray filename color instead of white because #fff makes it really fuzzy for some reason. Second one is using antialiased SourceSansPro SemiBold with no changes in color. |
I'm still saying. https://f.cloud.github.com/assets/1495261/1507856/69e41844-49b3-11e3-9f89-72c58bd27592.png Is not correct, for MacOSX I had this a while back. https://github.com/drewhjava/brackets-theme-update But it doesn't fix it in the later versions. That's why I started this topic. Later on I started using what njx mentioned in this issue. adobe/brackets#2791. (his last post) |
I just up voted this: https://trello.com/c/2nfWx6wX/353-3-user-specified-font |
Both 13px |
Brackets 33 on left Brackets 21 right. Also are you on Mavericks or Mountain Lion? |
|
Same is the case on Linux. Whatever anti-aliasing and stroke settings are being used, they make visibility quite frustrating. |
Adding CEF/Tracking labels as this may have been addressed in 1750 |
Too thin font As you can see, the font is significantly different depending on locale: |
I just opened a bug about this but it looks like this has already been closed? |
|
|
Friday Aug 02, 2013 at 19:30 GMT
Originally opened as adobe/brackets#4640
So you guys started off great. I think I came in at Sprint 15. This is a screenshot of Sprint 17. Great product. Great font rendering. Fast, sleek. Great editor. No modifications out of the box.
So then Sprint 20 came along and change some rendering. I was told to put subpixel-antialised to fix it. It was changed because of flickers during animation(which I have never actually seen and I've used this day in and day out for a while).
So then Sprint 27 comes a long. It brings worse performance, and of course worse font rendering. I try to fix it with subpixel-antialised, and it helps a little bit.
So then Sprint 28 gets launched, with even worse performance and worse font rendering. Now not even changing the font or font-rendering fixes it
![screen shot 2013-08-02 at 3 17 23 pm](https://camo.githubusercontent.com/0518fbbe193684dfb3864340c5e580874f672d6496d606f1003aa53e68795f3b/68747470733a2f2f662e636c6f75642e6769746875622e636f6d2f6173736574732f313035363538372f3930333336302f39346535663236382d666261392d313165322d386561662d3831376663353063633737322e706e67)
I know there was a switch in shell but why is everything getting so bad. I just want the team to download Sprint 17 and use it. Then go and use Sprint 28. You can't tell me it has gotten better.
Thanks
The text was updated successfully, but these errors were encountered: