Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Preference to change new font rendering #2791

Closed
drewhamlett opened this issue Feb 4, 2013 · 9 comments
Closed

Preference to change new font rendering #2791

drewhamlett opened this issue Feb 4, 2013 · 9 comments

Comments

@drewhamlett
Copy link
Contributor

Need preference or easy to way to get font rendering the way it was in Sprint 19 and below. If it messes up animation then have a setting to disable animation.

I feel like I'm on XP again

Also just add, none of the other editors I've used on MacOSX render fonts that light by default. Food for thought. I know there are animation issues but those could be disabled.

@njx
Copy link
Member

njx commented Feb 7, 2013

FYI, the animation issues are specifically because Brackets is built as a web app using Chromium, and the animations are done using CSS.

Marking move to backlog for now. If we get similar feedback from others once we release sprint 20, we might want to move this higher up on the backlog.

@drewhamlett
Copy link
Contributor Author

So when sprint 20 get's released how will I change the font rendering back? Is it just in one place or a few?

@redmunds
Copy link
Contributor

This is the pull request where font was updated: #2665

The entire font was updated, but I think that you might just be able to change this setting on brackets.less line 62 from:

  -webkit-font-smoothing: antialiased;

to:

-webkit-font-smoothing: subpixel-antialiased;

@njx
Copy link
Member

njx commented Feb 12, 2013

That will switch the antialiasing, but you'll still be using the heavier font that we introduced. To go back to the original font, you also need to remove the font-family entry from .code-font-mac() in brackets_theme_default.less.

@drewhamlett
Copy link
Contributor Author

Thanks guys. All is looking good in CM3 Preview version. Not exactly the same but close. Main difference is the gutter is padded out a little. Font is a little different. Less spacing in the letters CM3 test version. Letters may be too scrunched up in my opinion.

Real test is when I get on thunderbolt monitor tomorrow.

@njx
Copy link
Member

njx commented May 10, 2013

@drewhjava - closing this out for now. Let us know if you still have issues with the font rendering.

@njx njx closed this as completed May 10, 2013
@drewhamlett
Copy link
Contributor Author

@njx I've just been changing it manually every release. Haha. Maybe in future it will be easy to code out as an extension or something. Thanks.

@njx
Copy link
Member

njx commented May 10, 2013

Oh :) Well, you could conceivably write an extension to just change the antialiasing by dynamically creating a <style> block with body { -webkit-font-smoothing: subpixel-antialiased !important; }. The only issue is you'll be getting our current font weight, which is slightly bolder than the old font weight, so you'd probably need to override that manually too. Eventually we'll make fonts configurable...

@njx
Copy link
Member

njx commented May 10, 2013

(Or, for the first hack, you might even be able to just do $(document.body).css("-webkit-font-smoothing", "subpixel-antialiased").)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants