[CLOSED] Don't execute commands from the shell when a modal dialog is open.

[core-ai-bot]

Issue by gruehle
Saturday Jan 19, 2013 at 13:44 GMT
Originally opened as adobe/brackets#2617

---

This is a temporary quick fix for #2616

If a modal HTML dialog is open, don't execute commands that originate from the shell. The proper long-term solution is actually disabling command when a modal dialog is open, but that is a much bigger effort that should be a user story.

---

gruehle included the following code: https://github.com/adobe/brackets/pull/2617/commits

[core-ai-bot]

Comment by redmunds
Saturday Jan 19, 2013 at 17:30 GMT

---

reviewing

[core-ai-bot]

Comment by redmunds
Saturday Jan 19, 2013 at 17:45 GMT

---

This looks good on Win7.

On Mac 10.8, I can still execute commands in the Brackets menu, such as Quit and the Hide commands. Is that OK?

[core-ai-bot]

Comment by gruehle
Saturday Jan 19, 2013 at 19:26 GMT

---

That seems fine with me. Anyone else have objections?

[core-ai-bot]

Comment by peterflynn
Saturday Jan 19, 2013 at 22:05 GMT

---

The Mac issue was true in previous builds as well, since that native menu already existed.

[core-ai-bot]

Comment by redmunds
Saturday Jan 19, 2013 at 22:14 GMT

---

Merging.

[core-ai-bot]

Comment by peterflynn
Saturday Jan 19, 2013 at 22:31 GMT

---

I filed #2619 for the pre-existing bug with Quit being enabled while a quit dialog is already open. (It's not specific to menus either -- can also repro with the window close widget).