[CLOSED] Move file or folder to the trash

[core-ai-bot]

Issue by gruehle
Friday May 17, 2013 at 12:56 GMT
Originally opened as adobe/brackets#3879

---

Supersedes #2203

Add a "Delete" context menu item that moves the selected item (file or folder) to the trash/recycle bin.

The "move to trash" part is easy. The complicated parts are updating the tree and notifying the world that the file has been deleted.

---

gruehle included the following code: https://github.com/adobe/brackets/pull/3879/commits

[core-ai-bot]

Comment by gruehle
Friday May 17, 2013 at 12:57 GMT

---

@redmunds would you mind reviewing? I can rebase/squash once the review is complete.

[core-ai-bot]

Comment by pfarland
Friday May 17, 2013 at 17:55 GMT

---

Cool, delete was an obvious omission - glad we're addressing this!

[core-ai-bot]

Comment by redmunds
Friday May 17, 2013 at 18:53 GMT

---

Bug: Find in Files is not updated after a file is deleted. A reference to deleted file is still in list and displays an error if you click on it.

[core-ai-bot]

Comment by redmunds
Friday May 17, 2013 at 18:54 GMT

---

Bug: If you display an image in Quick View, delete the image, then go back and hover of the image reference again, the image is still displayed. Need to clear a cache somewhere?

[core-ai-bot]

Comment by redmunds
Friday May 17, 2013 at 19:00 GMT

---

Done with initial review

[core-ai-bot]

Comment by peterflynn
Friday May 17, 2013 at 21:46 GMT

---

Re Find in Files: does a similar bug exist with rename? If so the delete case seems puntable & the fixes should be lumped together...

[core-ai-bot]

Comment by redmunds
Friday May 17, 2013 at 22:14 GMT

---

Re Find in Files: does a similar bug exist with rename?

@peterflynn No, Find in Files results are correctly updated after a file is renamed.

[core-ai-bot]

Comment by gruehle
Friday May 17, 2013 at 22:44 GMT

---

Changes pushed:

• Find in Files results fixed
• skipAutoSelect is used

I couldn't find a reliable fix for the Quick View issue. CEF must be caching the image, and there is no way to clear the cache (short of a full refresh of Brackets, which seems excessive).

[core-ai-bot]

Comment by redmunds
Friday May 17, 2013 at 22:54 GMT

---

Looks good. Squash away!

[core-ai-bot]

Comment by gruehle
Friday May 17, 2013 at 23:03 GMT

---

Ugh. Rebasing 6 month old code is a pain... It would require fixing a ton of manual merge conflicts.

I could do a squashed commit, but then there would be a single commit from me, and I want to make sure@leonuh gets credit for his changes. Let's just merge as-is for now.

In the future, I'll make sure to do the rebase first if the changes are really old.

[core-ai-bot]

Comment by redmunds
Friday May 17, 2013 at 23:11 GMT

---

Merging.