Move file or folder to the trash #3879
Conversation
…ete on windows accepted
|
@redmunds would you mind reviewing? I can rebase/squash once the review is complete. |
ghost
assigned 
|
Cool, delete was an obvious omission - glad we're addressing this! |
| */ | ||
| function notifyFileDeleted(file) { | ||
| function notifyFileDeleted(file, skipAutoSelect) { |
There was a problem hiding this comment.
skipAutoSelect parameter is unused.
There was a problem hiding this comment.
Yep, that should have been passed to closeFullEditor(). Fixed.
|
Bug: Find in Files is not updated after a file is deleted. A reference to deleted file is still in list and displays an error if you click on it. |
|
Bug: If you display an image in Quick View, delete the image, then go back and hover of the image reference again, the image is still displayed. Need to clear a cache somewhere? |
|
Done with initial review |
|
Re Find in Files: does a similar bug exist with rename? If so the delete case seems puntable & the fixes should be lumped together... |
@peterflynn No, Find in Files results are correctly updated after a file is renamed. |
|
Changes pushed:
I couldn't find a reliable fix for the Quick View issue. CEF must be caching the image, and there is no way to clear the cache (short of a full refresh of Brackets, which seems excessive). |
|
Looks good. Squash away! |
|
Ugh. Rebasing 6 month old code is a pain... It would require fixing a ton of manual merge conflicts. I could do a squashed commit, but then there would be a single commit from me, and I want to make sure @leonuh gets credit for his changes. Let's just merge as-is for now. In the future, I'll make sure to do the rebase first if the changes are really old. |
|
Merging. |
Move file or folder to the trash
Supersedes #2203
Add a "Delete" context menu item that moves the selected item (file or folder) to the trash/recycle bin.
The "move to trash" part is easy. The complicated parts are updating the tree and notifying the world that the file has been deleted.