Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Fixed a few typos #9862

Open
core-ai-bot opened this issue Aug 30, 2021 · 6 comments
Open

[CLOSED] Fixed a few typos #9862

core-ai-bot opened this issue Aug 30, 2021 · 6 comments

Comments

@core-ai-bot
Copy link
Member

Issue by sprintr
Tuesday Jun 23, 2015 at 19:24 GMT
Originally opened as adobe/brackets#11302


Fixes a few typos in preferences description

CC:@abose


sprintr included the following code: https://github.com/adobe/brackets/pull/11302/commits

@core-ai-bot
Copy link
Member Author

Comment by abose
Wednesday Jun 24, 2015 at 05:36 GMT


Thanks@sprintr . merging.

@core-ai-bot
Copy link
Member Author

Comment by rawat11
Monday Jul 13, 2015 at 06:31 GMT


@sprintr Could you please check these strings (Do they hold specific meaning ?)

  • "True to allow unfiltered for in" (should it be translated as "True to allow unfiltering for inbound elements"?)
  • "True to allow stupidity"

@abose Can you check as well

@core-ai-bot
Copy link
Member Author

Comment by sprintr
Monday Jul 13, 2015 at 06:55 GMT


"True to allow unfiltered for in" (should it be translated as "True to allow unfiltering for inbound elements"?)

True to allow unfiltered for in seems fine to me. Reference

"True to allow stupidity"

This can be changed to True if blocking ('...Sync') methods can be used. Reference

@core-ai-bot
Copy link
Member Author

Comment by rawat11
Monday Jul 13, 2015 at 07:53 GMT


@sprintr Thanks. I do not have much idea on this.
If you are fine with first. then let it be like that. For second we can change it, leaving it to you.

@core-ai-bot
Copy link
Member Author

Comment by sprintr
Monday Jul 13, 2015 at 08:03 GMT


In the review of #11318, All of True were changed to the JavaScript Boolean true, so should we do the same for default locale?

@rawat11@abose@MarcelGerber

@core-ai-bot
Copy link
Member Author

Comment by abose
Monday Jul 13, 2015 at 10:26 GMT


@sprintr seems logical to use js boolean for me too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant