Fixed a few typos #11302

Merged
merged 1 commit into from Jun 24, 2015

Projects

None yet

3 participants

@sprintr
Contributor
sprintr commented Jun 23, 2015

Fixes a few typos in preferences description

CC: @abose

@abose abose merged commit 96f24bf into adobe:master Jun 24, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abose
Contributor
abose commented Jun 24, 2015

Thanks @sprintr . merging.

@sprintr sprintr deleted the sprintr:pref-desc-typos branch Jun 24, 2015
@rawat11
rawat11 commented Jul 13, 2015

@sprintr Could you please check these strings (Do they hold specific meaning ?)

  • "True to allow unfiltered for in" (should it be translated as "True to allow unfiltering for inbound elements"?)
  • "True to allow stupidity"

@abose Can you check as well

@sprintr
Contributor
sprintr commented Jul 13, 2015

"True to allow unfiltered for in" (should it be translated as "True to allow unfiltering for inbound elements"?)

True to allow unfiltered for in seems fine to me. Reference

"True to allow stupidity"

This can be changed to True if blocking ('...Sync') methods can be used. Reference

@rawat11
rawat11 commented Jul 13, 2015

@sprintr Thanks. I do not have much idea on this.
If you are fine with first. then let it be like that. For second we can change it, leaving it to you.

@sprintr
Contributor
sprintr commented Jul 13, 2015

In the review of #11318, All of True were changed to the JavaScript Boolean true, so should we do the same for default locale?

@rawat11 @abose @MarcelGerber

@abose
Contributor
abose commented Jul 13, 2015

@sprintr seems logical to use js boolean for me too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment