Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Badges support #26

Merged
merged 2 commits into from
Oct 1, 2017
Merged

Badges support #26

merged 2 commits into from
Oct 1, 2017

Conversation

KatieMFritz
Copy link
Contributor

I noticed that there was a badges.html being included in the page-header.html but the styles were never defined, and the badges weren't showing up in the component view.

  • added badge support to component-category.html'
  • refactored badges.html to account for the component-category.html using componentPage.status instead of page.status
  • added various statuses to the three components in the Blocks and Cards component directory to test
  • added some basic badge styles (should we be worried about font size/accessibility?)
  • converted tabs to spaces on style-guide.scss, hopefully not messing things up too badly 😬

@bradfrost bradfrost merged commit 750046b into bradfrost:master Oct 1, 2017
@bradfrost
Copy link
Owner

Hey @KatieMFritz! Thanks so much for the tremendous contribution. Thanks for the eagle-eye on noticing the badges in the first place, and for bringing them to life. The project the Style Guide Guide was born from made ample use of the badges, but I clearly didn't get around to translating them into this project. Thanks again!

@Ryuno-Ki Ryuno-Ki mentioned this pull request Nov 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants