Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload permissions & Widgets #11

Closed
codingjoe opened this issue May 6, 2014 · 5 comments
Closed

Upload permissions & Widgets #11

codingjoe opened this issue May 6, 2014 · 5 comments

Comments

@codingjoe
Copy link

Hi, I like to contribute come changes regarding permissions (currently staff only) and useage/usecase documentation.
I think it's better to simply use the widget and you field of choice. I'd even like to add multiple widgets that ave different compression value types, that they my return a django File, instead of an URL.

If you're cool with it I'd sit down and implement it.

@bradleyg
Copy link
Owner

bradleyg commented May 6, 2014

Sounds good, especially returning a django file rather than a URL, I've been meaning to implement that for a while.

@codingjoe
Copy link
Author

@bradleyg I just realised that your repo is missing a license. I strongly encourage you to add one, preferably MIT License.

bradleyg added a commit that referenced this issue May 7, 2014
@codingjoe
Copy link
Author

Thanks, for the license. I already started developing the additional features. I will add unit tests and CI as well, to get the package on production level.

@codingjoe
Copy link
Author

Almost done, I just gonna wrap it up and add some documentation.

@codingjoe
Copy link
Author

closed in favour of pull request

bport pushed a commit to bport/django-s3direct that referenced this issue Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants