Skip to content
This repository has been archived by the owner on Jan 19, 2019. It is now read-only.

[FIX] [no-use-before-define] fix top level scope handling #175

Merged
merged 4 commits into from
Nov 21, 2018
Merged

[FIX] [no-use-before-define] fix top level scope handling #175

merged 4 commits into from
Nov 21, 2018

Conversation

bradzacher
Copy link
Owner

Fixes #142

The problem was it was failing to accept the case when both the def and the var were in the top-level global/module scope

weirdpattern
weirdpattern reviewed Nov 21, 2018
View reviewed changes
Copy link
Collaborator

@weirdpattern weirdpattern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the casing on that one method, everything else looks OK to me.
Not a major thing... so not really requesting changes, just a comment 😄

lib/rules/no-use-before-define.js Outdated Show resolved Hide resolved
@bradzacher bradzacher merged commit 5192c20 into master Nov 21, 2018
@bradzacher bradzacher deleted the 142-no-use-before-define branch November 21, 2018 16:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@weirdpattern weirdpattern weirdpattern left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bradzacher @weirdpattern