Skip to content
This repository has been archived by the owner on Jan 19, 2019. It is now read-only.

Fix: Mark qualified name type annotations as used #88

Merged
merged 1 commit into from
Nov 23, 2017
Merged

Fix: Mark qualified name type annotations as used #88

merged 1 commit into from
Nov 23, 2017

Conversation

timothykang
Copy link
Contributor

No description provided.

mightyiam
mightyiam reviewed Oct 21, 2017
View reviewed changes
Copy link
Contributor

@mightyiam mightyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about a test for Foo.Bar.Baz?

@timothykang
Copy link
Contributor Author

Good call, updated.

@mightyiam
Copy link
Contributor

Does this fix any filed issue?

@timothykang
Copy link
Contributor Author

None that I could find.

I encountered the bug myself and was about to create an issue and PR with a failing test, but then thought why not just fix it while I was at it.

@JamesHenry
Copy link
Collaborator

Thanks a lot for your patience on this, @timothykang!

@JamesHenry JamesHenry merged commit 29bd53c into bradzacher:master Nov 23, 2017
@timothykang timothykang deleted the fix-qualified-name branch April 13, 2018 15:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mightyiam mightyiam mightyiam left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timothykang @mightyiam @JamesHenry