This repository has been archived by the owner on Jan 19, 2019. It is now read-only.
Fix: Mark call expression type parameters as used #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mightyiam
suggested changes
Oct 25, 2017
| @@ -186,6 +186,28 @@ ruleTester.run("no-unused-vars", ruleNoUnusedVars, { | |||
| }, | |||
| { | |||
| code: [ | |||
| "import { Foo } from 'foo'", | |||
| "function bar<T>() {}", | |||
| { | ||
| code: [ | ||
| "import { Foo } from 'foo'", | ||
| "const bar = <T>() => {}", |
There was a problem hiding this comment.
Arrow function by reference.
| parser | ||
| }, | ||
| { | ||
| code: ["import { Foo } from 'foo'", "<Foo>(<T>() => {})()"].join( |
There was a problem hiding this comment.
Immediately invoked arrow function...
lib/rules/no-unused-vars.js
Outdated
| }); | ||
| annotation.typeParameters.params.forEach( | ||
| markTypeAnnotationAsUsed | ||
| ); |
There was a problem hiding this comment.
👍 in general. 👎 for being unrelated.
|
Updated to incorporate feedback, and added an invalid test case as well. |
mightyiam
reviewed
Oct 25, 2017
| { | ||
| code: [ | ||
| "import { Foo } from 'foo'", | ||
| "const bar = function <T>() {}", |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While type parameters on function declarations/expressions are marked as used, ones on call expressions are not, e.g.: