Segfault in spd_close()

[Parakleta]

The changes made in dc945d8 lead to a SegFault on FreeBSD due to an attempt to close a null FILE *.

I think the relevant code should look like:

    if (connection->stream != NULL)
        fclose(connection->stream);
    connection->stream = NULL;
    close(connection->socket);

This mimics the closure behaviour on error in get_reply() in the same file.

[sthibaul]

Thanks for the report!
(I however don't think we shall close the underlying socket, fclose does that already)

[Parakleta]

Yes, you are correct. I hadn’t followed the fdopen behaviour correctly.

I based my assumptions off the behaviour here:

speechd/src/api/c/libspeechd.c

Lines 565 to 567 in c204a23

	fclose(connection->stream);
	close(connection->socket);
	free(connection);