Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add how to install Bundler #11

Merged
2 commits merged into from
May 11, 2022
Merged

Add how to install Bundler #11

2 commits merged into from
May 11, 2022

Conversation

ghost
Copy link

@ghost ghost commented May 11, 2022

Add how to install bundler

主な変更点

  • ruby-full でデフォルトで Bundler がインストールされてなかったため、gem でインストールする方法を追記(Wiki の編集方法とルール)

軽微な変更点

  • 英語混じり日本文の 分かち書き の有無が混在していたため、他のページに合わせ「あり」に統一 (Wiki の編集方法とルール)
  • npm (textlint|mdlint) -> npm **run** (textlint|mdlint) に修正 (「各種操作」セクション / Wiki の編集方法とルール)
  • 編集権限のあるメンバーとして、@Sasakura-ayato を追記 (「変更を提出する」セクション / Wiki の編集方法とルール)
    -《追記》さらに、 @Codex340 さんも追記
  • その他、軽微な修正

連絡

  • 全角記号のあとの英語には、原則分かち書きを施していません。(例:「……Jekyll は、md ファイル……」など)

@ghost ghost requested review from puhitaku and Codex340 May 11, 2022 13:59
Copy link
Member

@puhitaku puhitaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

レビューしましたー
(僕がむしろ致命的なミスしててすいませんでしたw)

_posts/2021-12-04-meta-how-to-edit-wiki.md Outdated Show resolved Hide resolved
_posts/2021-12-04-meta-how-to-edit-wiki.md Outdated Show resolved Hide resolved
_posts/2021-12-04-meta-how-to-edit-wiki.md Outdated Show resolved Hide resolved
_posts/2021-12-04-meta-how-to-edit-wiki.md Show resolved Hide resolved
_posts/2021-12-04-meta-how-to-edit-wiki.md Show resolved Hide resolved
_posts/2021-12-04-meta-how-to-edit-wiki.md Outdated Show resolved Hide resolved
@ghost ghost requested review from puhitaku and Threebents May 11, 2022 15:39
Copy link
Member

@puhitaku puhitaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
lgtm_brain2

@ghost
Copy link
Author

ghost commented May 11, 2022

Merge :done: !

@ghost ghost merged commit 11199bf into master May 11, 2022
@ghost ghost deleted the 2022-05-11 branch May 11, 2022 16:01
@Threebents
Copy link
Contributor

LGTM!

@ghost
Copy link
Author

ghost commented May 11, 2022

ありがとうございます!

@ghost ghost removed the request for review from Codex340 May 12, 2022 05:13
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants