Fix #42 #50
Merged
Fix #42 #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following the link below we can see that this is a bug in llvm config, not our fault. So I'm adding the -Wno-unknown-option to Makefile Link atesting the bug: https://bugs.llvm.org/show_bug.cgi?id=24979 Signed-off-by: Rafael Campos Nunes <rafaelnunes@engineer.com>
It makes the code non portable when running on non unix machines because of dirent and also ANSI escape code sequences, if we want to go portable we should do something about it. Signed-off-by: Rafael Campos Nunes <rafaelnunes@engineer.com>
|
Hi @rafaelcn , could you check if this link is broken? https://bugs.llvm.org/show_bug.cgi?id=24979 |
|
I've just accessed it 😃 |
luizperes
approved these changes
Oct 16, 2017
|
That's where I got it from! xD |
|
Hi @rafaelcn, just wait for travis to test your latest change and you can merge it! :D Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the link below we can see that this is a bug in llvm
config, not our fault. So I'm adding the -Wno-unknown-option to Makefile
Link atesting the bug: https://bugs.llvm.org/show_bug.cgi?id=24979
Signed-off-by: Rafael Campos Nunes rafaelnunes@engineer.com