Syncing from upstream odoo/odoo (saas-16.2) #20158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the multi-company context, it is possible to create an analytic account without a defined company. The result is that the analytic account will not have a currency. A traceback will be triggered when calculating the profitability of a project (for example by changing its status when the 'sale_timesheet' module is installed). Solution: Use the currency of the project. Introduced by: 68b4ea6 opw-3292417 closes #121132 X-original-commit: 90512da Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com> Signed-off-by: Lefebvre Thomas (thle) <thle@odoo.com>
Previous commit 1b840d0 tried to fix the issue action_generate_serial may try to generate a existing lot. But it made the lot number completely product specific. This change is too big for stable, we revert the change in this commit. Also to fix the issue, when action_generate_serial tries to generate a lot, we always try the result from ir.sequence frist, only when the lot already exists, we then try create one based on the product's lastest lot number. Task-3187003 closes #121210 X-original-commit: 95214ab Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com> Signed-off-by: Yuchen Huang (yhu) <yhu@odoo.com>
Since e6415be, it is forbidden to use taxes on Sales Order Lines from another company than the Sales Order one (it was breaking later in the flows anyway). Nevertheless, in some flows, modifying the company of an existing SO can make sense, but you wouldn't be able to save the change if taxes were set on the lines (unless you trigger the 'Update Taxes' button). This commit will make sure that taxes are automatically recomputed on company change, s.t. the user doesn't face multi-company errors. It'll magically change taxes & amounts, but we consider that it's an expected behavior when modifying the order company (and an advanced flow for which users must be aware of the consequences). Anyway, the user will always be able to discard the changes (company & company-based recomputations) if needed. opw-3234905 closes #121230 X-original-commit: e2aad2e Related: odoo/enterprise#40973 Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
Commit [1] defined a value for the `onWysiwygBlur` option of `Wysiwyg` in the `mass_mailing` `html field`. This had the side effect of overriding the value set by its parent `html field`, which was to call `commitChanges`. As a result, the `mass_mailing` `html field` was not saving its content on blur. This restores that behavior by explicitly adding the call to `commitChanges` where it was missing. [1]: e212e87 task-3288881 closes #121229 X-original-commit: 817d494 Signed-off-by: David Monjoie (dmo) <dmo@odoo.com> Signed-off-by: Antoine Guenet (age) <age@odoo.com>
This commit modifies `execute` method to avoid `MissingError` on reading `template_ref` field. `template_ref` is a Reference field, which may have id of a deleted record. https://github.com/odoo/odoo/blob/927890d0178c361ef8d80fe6a1ec2ffaefaf73fd/addons/event/models/event_mail.py#L53 Method `execute` is used by cron. https://github.com/odoo/odoo/blob/fba13477843d4d36e3e7a9ddd4b0812c9726e20c/addons/event/data/ir_cron_data.xml#L4-L8 https://github.com/odoo/odoo/blob/927890d0178c361ef8d80fe6a1ec2ffaefaf73fd/addons/event/models/event_mail.py#L247-L256 Getting the `MissingError` means blocking processing the whole batch of tickets. Fix it by ignoring such tickets and logging a warning https://online.sentry.io/issues/4089773378 closes #121190 X-original-commit: c61a8fb Signed-off-by: Ivan Elizaryev (iel) <iel@odoo.com>
This commit is simply conditionning the presence of the /website/info page in the sitemap so it's removed from it if you disable/remove the website info view. It will help SEO wise to not have error page in it. Also note that it has always been in sitemap, even if marked excplicitely since [1]. [1]: e19227d#diff-d41b2dc5ff6fd6a303373f86e1af97d055db315ccc431749b4ffac1488dea119L200 opw-3255831 closes #121221 X-original-commit: b4ae4a0 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com> Signed-off-by: Romain Derie (rde) <rde@odoo.com>
Before this commit, when having a x2many field invisible in a view, and displaying it anyway in studio, there was a crash because some variable was undefined. This originated from commit f22961a, which did not account for the fact that viewMode is an optional props. After this commit, the util function used by the x2m field and where the crash occur has been refactored. Moreover, the x2m field template has also been slightly refactored. backport of: 2ddc734 closes #121259 Taskid: 3305808 Related: odoo/enterprise#40995 Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>
With a slow network, make a new search in the search bar of a graph view would lead the graph renderer to be rendered twice. This was due to the fact that in the graph controller template an arrow function is passed as a prop to the graph renderer. The reactivity system treats that prop as changing at each graph controller rendering and ask unnecessarily (in this case) the graph renderer to render. closes #121287 X-original-commit: dab0187 Signed-off-by: Géry Debongnie <ged@odoo.com>
Prior to this commit, after [1], when a user is trying to visit or view their website from a domain that is not their current website, a traceback would appear if the redirect took too long. This is because when redirecting, we do not set any URL as the iframe iframe source, so it loads the `about:blank` page. When trying to push that page into the history (done to change the name and url displayed in the browser), the browser crashes and displays a CORS error. On top of that, it seems some users do not understand what is happening and feel like they are being logged out if they're not logged into their custom domains. This commit prevents replacing the history state if the page displayed in the iframe is `about:blank`. It also displays a dialog before redirecting, explaining to the user why it is necessary. Steps to reproduce: - Go to website settings - Set a domain for your website that's different from the one you are currently using to access Odoo (Could be anything but for a realistic setup, if accessing from localhost, use 127.0.0.1 or the other way around, or use different 127.0.0.X ips) - Toggle a slow network mode from your browser's dev tools (This is to ensure the traceback appears as it does not if the network is quick enough with its redirect) - Go on the website app => A traceback appears (and disappears as the page is unloaded) [1]: 59b96b0 opw-3250663 closes #121303 X-original-commit: 15a31cb Signed-off-by: Romain Derie (rde) <rde@odoo.com>
To Reproduce ============ - create two Vendor Bills and attach to each one a PDF from the ones provided by the client on the ticket. - select these two bills and and try to print Original Bills an error will be raised Problem ======= while merging these PDFs, PyPDF2 throws a `TypeError` which is not caught by the server Solution ======== catch `TypeError` to raise a UserError opw-3285540 closes #121306 X-original-commit: 5053620 Signed-off-by: abla001 <abla@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bt_gitbot