Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preprocessing classes #500

Merged
merged 35 commits into from
Sep 8, 2023
Merged

Preprocessing classes #500

merged 35 commits into from
Sep 8, 2023

Conversation

brunaafl
Copy link
Collaborator

@brunaafl brunaafl commented Sep 5, 2023

-Not finished (+revising)
-Delete some comments
NOTE: pick_types() is a legacy function. New code should use inst.pick(...). --> so, I still need to change to pick

@codecov
Copy link

codecov bot commented Sep 5, 2023 •
edited

Codecov Report

Merging #500 (c7364dd) into master (264c775) will increase coverage by 0.08%.
The diff coverage is 96.66%.

@@            Coverage Diff             @@
##           master     #500      +/-   ##
==========================================
+ Coverage   84.27%   84.36%   +0.08%     
==========================================
  Files          62       63       +1     
  Lines        4465     4495      +30     
==========================================
+ Hits         3763     3792      +29     
- Misses        702      703       +1

📢 Have feedback on the report? Share it here.

@brunaafl
Create side preprocessing classes based on mne (still revising)
dd8e724
@brunaafl
Create side preprocessing classes based on mne (still revising)
cc91059
@brunaafl
Create side preprocessing classes based on mne (still revising)
0348d55
@brunaafl
Create side preprocessing classes based on mne (still revising)
6561517
@brunaafl
Create side preprocessing classes based on mne (still revising)
1f2a02c
@brunaafl
Create side preprocessing classes based on mne (still revising)
aeb378a
@brunaafl
Test file for the new functions
37e4087
@brunaafl
Test file for the new functions
2548682
@brunaafl
Create side preprocessing classes based on mne (still revising)
6319f42
@brunaafl
Test file for new classes
0d1728a
@brunaafl
Create side preprocessing classes based on mne (still revising)
c785c0a
@brunaafl
adding pytest_cases
4f6e95f
@brunaafl
Adding new comments
7a63b9e
@brunaafl
Adding new comments
b69275d
@brunaafl
Adding new comments
c8a13fd
@brunaafl
Copy link
Collaborator Author

brunaafl commented Sep 6, 2023

  • Created some new preprocessor objects based on mne's raw/Epochs methods (in preprocess_classes.py), with docstrings copied from mne
  • Created a test file (test_new_preprocess.py) with some tests adapted from the Preprocessor's test (test_preprocess.py).
  • Commenting
  • Still did not update whats new file
    Still needs to be reviewed

@brunaafl
Copy link
Collaborator Author

brunaafl commented Sep 7, 2023

  • Added the new preprocessor classes to the API reference
  • Fixed the copy docstring from mne
    @robintibor
    I still need to update the what's new file

sylvchev
sylvchev reviewed Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@sylvchev sylvchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me, I could not check the tests.

braindecode/preprocessing/preprocess_classes.py Outdated Show resolved Hide resolved
braindecode/preprocessing/preprocess_classes.py Outdated Show resolved Hide resolved
.github/workflows/tests.yml Outdated Show resolved Hide resolved
braindecode/preprocessing/preprocess_classes.py Outdated Show resolved Hide resolved
braindecode/preprocessing/preprocess_classes.py Outdated Show resolved Hide resolved
braindecode/preprocessing/preprocess_classes.py Outdated Show resolved Hide resolved
braindecode/preprocessing/preprocess_classes.py Outdated Show resolved Hide resolved
braindecode/preprocessing/preprocess_classes.py Outdated Show resolved Hide resolved
braindecode/preprocessing/preprocess_classes.py Outdated Show resolved Hide resolved
braindecode/preprocessing/preprocess_classes.py Outdated Show resolved Hide resolved
bruAristimunha and others added 2 commits September 7, 2023 16:23
@bruAristimunha @sliwy
Apply suggestions from code review
1f05e7f 
Co-authored-by: Maciej Sliwowski <macieksliwowski@gmail.com>
@bruAristimunha
Creating based on the function
0a1e5a5
sliwy
sliwy previously requested changes Sep 7, 2023
View reviewed changes
braindecode/preprocessing/mne_preprocess.py Outdated Show resolved Hide resolved
braindecode/preprocessing/mne_preprocess.py Outdated Show resolved Hide resolved
braindecode/preprocessing/preprocess_classes.py Outdated Show resolved Hide resolved
braindecode/preprocessing/mne_preprocess.py Show resolved Hide resolved
sylvchev
sylvchev approved these changes Sep 8, 2023
View reviewed changes
Copy link
Collaborator

@sylvchev sylvchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to add what's new and remove mne_preprocess.py, and it is good to merge.
Great job @brunaafl & @bruAristimunha !

braindecode/preprocessing/preprocess_classes.py Outdated Show resolved Hide resolved
braindecode/preprocessing/mne_preprocess.py Show resolved Hide resolved
braindecode/preprocessing/mne_preprocess.py Outdated Show resolved Hide resolved
test/unit_tests/preprocessing/test_new_preprocess.py Outdated Show resolved Hide resolved
test/unit_tests/preprocessing/test_new_preprocess.py Outdated Show resolved Hide resolved
test/unit_tests/preprocessing/test_new_preprocess.py Outdated Show resolved Hide resolved
test/unit_tests/preprocessing/test_new_preprocess.py Outdated Show resolved Hide resolved
sylvchev
sylvchev reviewed Sep 8, 2023
View reviewed changes
setup.py Show resolved Hide resolved
@robintibor robintibor dismissed sliwy’s stale review September 8, 2023 11:19

Changes have been done

@robintibor robintibor merged commit 57280a6 into braindecode:master Sep 8, 2023
15 checks passed
dcwil pushed a commit to dcwil/braindecode that referenced this pull request Sep 11, 2023
@brunaafl @bruAristimunha
@sliwy @dcwil
Preprocessing classes (braindecode#500)
38daba9 
* Create side preprocessing classes based on mne (still revising)

* Create side preprocessing classes based on mne (still revising)

* Create side preprocessing classes based on mne (still revising)

* Create side preprocessing classes based on mne (still revising)

* Create side preprocessing classes based on mne (still revising)

* Create side preprocessing classes based on mne (still revising)

* Create side preprocessing classes based on mne (still revising)

* Create side preprocessing classes based on mne (still revising)

* Create side preprocessing classes based on mne (still revising)

* Create side preprocessing classes based on mne (still revising)

* Create side preprocessing classes based on mne (still revising)

* Test file for the new functions

* Test file for the new functions

* Create side preprocessing classes based on mne (still revising)

* Test file for new classes

* Create side preprocessing classes based on mne (still revising)

* adding pytest_cases

* Adding new comments

* Adding new comments

* Adding new comments

* Copying docstring from mne methods

* Adding new classes to documentation

* Adding new classes to API

* Copying docstring

* Copying docstring

* Updating the setup

* Apply suggestions from code review

Co-authored-by: Maciej Sliwowski <macieksliwowski@gmail.com>

* Creating based on the function

* Making private

* Fixing doc

* Removing

* Removing

* Updating the requirements.txt

* Updating the whats_new.rst

---------

Co-authored-by: Bru <a.bruno@aluno.ufabc.edu.br>
Co-authored-by: Maciej Sliwowski <macieksliwowski@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylvchev sylvchev sylvchev approved these changes

@bruAristimunha bruAristimunha bruAristimunha left review comments

@robintibor robintibor Awaiting requested review from robintibor

@sliwy sliwy Awaiting requested review from sliwy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@brunaafl @sylvchev @sliwy @bruAristimunha @robintibor