Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent packaging of napari backends in optional dependencies #53

Open
alessandrofelder opened this issue Nov 27, 2023 · 4 comments
Open
Assignees

Comments

@alessandrofelder
Copy link
Member

alessandrofelder commented Nov 27, 2023

Across all packages, I would suggest we should:

  • always NOT ship any qt backend in [napari] optional dependencies to follow napari plugin best practice.
  • always ship napari[pyqt5] or whatever the napari default backend is, in the [dev] optional dependencies
@alessandrofelder
Copy link
Member Author

We should also document this as part of brainglobe/brainglobe.github.io#8

@alessandrofelder alessandrofelder self-assigned this Nov 27, 2023
@adamltyson
Copy link
Member

We need to ship napari in some way though right? Otherwise it complicates install for the user. What about:

  • Don't ship in the plugins themselves
  • Ship default backend in the metapackage

@alessandrofelder
Copy link
Member Author

What about:
...

Happy with that. The drawback of this suggestion is if people install with pyside2 for some license-related reason, installing the metapackage will be complicated?

@adamltyson
Copy link
Member

Happy with that. The drawback of this suggestion is if people install with pyside2 for some license-related reason, installing the metapackage will be complicated?

I guess the fallback here will just be to install the packages individually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Planned
Development

No branches or pull requests

2 participants