Fix NumPy future warning on get structure mask #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The boolean-valued array was wrapped in another array previously
|
Thanks @seankmartin! @vigji, @FedeClaudi was there any reason for this syntax originally? |
|
Thanks for the PR! I can't see a good reason for keeping the previous structure, happy to merge it if @FedeClaudi agrees |
|
@FedeClaudi happy to merge? |
|
Yep, good to merge. |
|
Great, thanks @seankmartin! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks so much for the package, it is great!
One small thing I noticed on the latest version:
In core.py line 349, the boolean-valued array was wrapped inside another array.
I may have missed a reason for this, but the extra array brackets [] shouldn't be needed.
This line throws a future warning on the latest version of NumPy.
The new code also matches the code on line 348 for checking descendants.