Changes to config file location #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default directory changed from within site-packages to <HOME>/.config/brainglobe . User can override with env var BRAINGLOBE_CONFIG_DIR.
Fixed bug in config.write_config_value where config file was written to default location even if custom path passed in. This change allows the caller to override the config directory in code, which takes precedence over the default location and the BRAINGLOBE_CONFIG_DIR variables. Clients can use this to set the config dir via their command-line flags.
|
Thanks @chrisroat! This looks fine to me. If you could just ensure the tests pass - I think you'll just need to run black: Happy to merge when you are @vigji, @FedeClaudi. |
|
Added commit to blacken. |
|
Looks good to me! Definitively better this way. Thanks @chrisroat, and sorry for the delayed review! Good to merge for me |
adamltyson
approved these changes
Dec 31, 2021
vigji
requested changes
Dec 31, 2021
|
flaked |
|
Happy to merge once @FedeClaudi has OK'd it. |
vigji
approved these changes
Dec 31, 2021
|
looks good to me |
FedeClaudi
approved these changes
Dec 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change config file directory. Default directory changed from within site-packages to /.config/brainglobe . User can override with env var BRAINGLOBE_CONFIG_DIR.
Add config dir parameter to BrainGlobeAtlas
Fixed bug in config.write_config_value where config file was written to default location even if custom path passed in.
This change allows the caller to override the config directory in code, which takes precedence over the default location and the BRAINGLOBE_CONFIG_DIR variables. Clients can use this to set the config dir via their command-line flags.